Closed
Bug 763610
Opened 12 years ago
Closed 8 years ago
test_name_extension should probably go away
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(firefox49 fixed)
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: k0scist, Assigned: malayaleecoder)
References
Details
(Whiteboard: [talos_wishlist])
Attachments
(1 file)
(deleted),
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
We have a configuration variable, test_name_extension, that will be appended to the test name and counter names *only* for tp tests. As far as I know, this is not used in production and provides extra complication.
Reporter | ||
Comment 1•12 years ago
|
||
This is not settable from the CLI but values like _paint and _nochrome are added from PerfConfigurator.py . If we can't eliminate this altogether, it would help if we could at least do this for ts tests as well as tp tests
Reporter | ||
Comment 2•12 years ago
|
||
Also, once datazilla is a reality and graphserver is obseleted these can go away (along with a helluva lot more other stuff)
Comment 3•9 years ago
|
||
sadly this bug still exists- when we stop uploading to graph server, this can go away- maybe a few more months!
Comment 4•8 years ago
|
||
ok, graph server is not being used anymore, we can move forward on this bug!
Updated•8 years ago
|
Whiteboard: [talos_wishlist]
Assignee | ||
Comment 5•8 years ago
|
||
I would like to give this a try :)
Updated•8 years ago
|
Assignee: nobody → malayaleecoder
Assignee | ||
Comment 6•8 years ago
|
||
The tests pass locally, please push to try and verify there also :)
Comment 7•8 years ago
|
||
push to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca7ae59fd8d4
Comment 8•8 years ago
|
||
the try push looks good- if you think the patch is ready, please edit the details of the attachment and ask me for review :)
Assignee | ||
Updated•8 years ago
|
Attachment #8755594 -
Flags: review?(jmaher)
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Comment 9•8 years ago
|
||
Comment on attachment 8755594 [details] [diff] [review] Bug763610_v1.diff Review of attachment 8755594 [details] [diff] [review]: ----------------------------------------------------------------- thanks, this is a great first patch for talos!
Attachment #8755594 -
Flags: review?(jmaher) → review+
Updated•8 years ago
|
Keywords: checkin-needed
Comment 10•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b2a710d35e6
Keywords: checkin-needed
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0b2a710d35e6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•