This function (which traces through JS objects for the cycle collector) is pretty big, but there are a few separate steps it takes, so I'd like to break it up a bit. There's probably also some other cleanup I can do at the same time. This will also make it easier for me to alter its behavior for CompartmentParticipant in bug 754495.

This causes slightly more work, but only when we're logging.

This will be bit rotted by bug 616262, but only in a trivial way.

Comment on attachment 633608 [details] [diff] [review] part 1: add redundant vars to enable outlining Please review the rest of the patches, too, I just think there's no need to spam the bug by setting the review flag on every piece.

I'll leave the main thread cleanup stuff for another patch, after XPC singlethreading lands. Or maybe it will just fix it. Either way.

Comment on attachment 633608 [details] [diff] [review] part 1: add redundant vars to enable outlining Is this all you wanted me to review? As an aside, I think it would be nice if we could replace uses of |clazz| in xpconnect with |clasp|, which is what we use in the JS engine.

Sure, I can do that for the code I touch in these patches.

Comment on attachment 634172 [details] [diff] [review] part 6: clazz to clasp Excellent, thanks!

Thanks for the reviews! Try run looked good. Landed the patch in one chunk. https://hg.mozilla.org/integration/mozilla-inbound/rev/9118e53405c7