Closed Bug 76382 Opened 24 years ago Closed 22 years ago

Disable the Properties toolbar button and menu item when focus is on Address Book

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED WORKSFORME
mozilla1.4beta

People

(Reporter: fenella, Assigned: shliang)

References

Details

(Whiteboard: [adt3] have fix,nab-ab)

Attachments

(1 obsolete file)

Linux (2001-04-17-08 trunk) Win32 (2001-04-17-06 trunk) Mac (2001-04-17-04 trunk) 1. Open Address Book from the Task menu 2. Set focus on the Personal address book 3. Select Edit|Card Properties. Actual result: It does not bring up the dialog for the Personal Address Book. Instead, it brings up the "Card for the card or list" that has the focus set on the result pane. Expected result: Per spec., it should bring up the property dialog for the Address Book because I have set focus on the Personal Address Book. This occurs on all three platforms.
Summary: [Feature]Edit|Card Properties on Addr. Book → [Feature]Edit|Card Properties on Addr. Book
Edit "Card Properties..." should be "Address Book Properties..." when an AB has focus. http://www.mozilla.org/mailnews/specs/addressbook/AB_Menus.html
QA Contact: esther → fenella
I know this probably won't make beta, but rtm would be nice (was sure how to nominate it for rtm). Address Book is not as high profile as other components, but the current behavior is wrong and should be fixed.
Keywords: nsbeta1, nsCatFood
marking nsbeta1+ and moving to 0.9.2
Priority: -- → P3
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9.2
Scott and I talked and we decide to do a simple fix on this bug instead of implement the edit address book property. The fix will disable the Edit button and Card properties menu item when user click on the left pane.
Status: NEW → ASSIGNED
Attached patch Patch for disable the edit button and menu item (obsolete) (deleted) — Splinter Review
Whiteboard: [nsbeta1+] → [nsbeta1+]have fix
moving to 0.9.3. Please hold onto the fix in case we can get this in later.
Target Milestone: mozilla0.9.2 → mozilla0.9.3
If this bug does end up disabling the Properties menu item when an Address Book has focus, please be sure to create a different bug for adding this feature back in at a later time. (or create a different bug to disable the menu item as a temporary solution)
Bug 60370 is a dup for this one.
Change summary to reflect the fix for this bug, bug 60370 now is for "Address Book Properties...".
Summary: [Feature]Edit|Card Properties on Addr. Book → Disable the Edit button and Card property Menu when focus is on Address Book
moving to 0.9.4
Target Milestone: mozilla0.9.3 → mozilla0.9.4
moving to 0.9.5
Target Milestone: mozilla0.9.4 → mozilla0.9.5
QA Contact: fenella → nbaca
moving to 0.9.6
Target Milestone: mozilla0.9.5 → mozilla0.9.6
reassigning to racham
Assignee: chuang → racham
Status: ASSIGNED → NEW
moving to 1.0, though if we could get the patch in it would be good.
Target Milestone: mozilla0.9.6 → mozilla1.0
Blocks: 104166
Keywords: nsbeta1
Whiteboard: [nsbeta1+]have fix → have fix
Keywords: nsbeta1nsbeta1-
Target Milestone: mozilla1.0 → mozilla1.0.1
Comment on attachment 35975 [details] [diff] [review] Patch for disable the edit button and menu item what ever this patch is, I'm sure it's obsolete.
Attachment #35975 - Attachment is obsolete: true
is this bug invalid? We now have a Properties toolbar button and a Properties menu item, and those work when the directory tree has focus. (at least, when mailing list is selected.) at some point, they should work for addressbooks, as local addressbooks will have editable properties (name) and LDAP addressbooks will have properties (SSL or non-SSL, port, host, name, etc.)
Summary: Disable the Edit button and Card property Menu when focus is on Address Book → Disable the Properties toolbar button and menu item when focus is on Address Book
Seth, this bug was originally writen because an AB can be selected, the "Properites" button/menu item is enabled, but clicking does nothing. Instead of fixing it, bug was morphed into "Disable the Properties menu/button when an AB has focus". Both issues are still valid. #1 was a temp fix. #2 is the permanent/correct fix. 1. If an AB has focus, but "Properties" button/menu doesn't work yet, we should disable the button/menu. 2. AB selected, "Properties" button/menu clicked should open "Address Book Properites" dialog.
bug 17230 is for implementing the AB Properties dialog.
Whiteboard: have fix → have fix,nab-ab
Blocks: 156960
Marking nsbeta1, see comment# 17 for implementation.
Keywords: nsbeta1-nsbeta1
Mail triage team: nsbeta1+/adt3
Keywords: nsbeta1nsbeta1+
Whiteboard: have fix,nab-ab → [adt3] have fix,nab-ab
Reassigning.
Assignee: racham → shliang
Target Milestone: mozilla1.0.1 → mozilla1.4beta
clicking properties now brings up the rename addressbook dialog (bug #17230)
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → WORKSFORME
Trunk build 2003-05-20: WinMe, Mac 10.1.5, Linux RH 8 Verified Worksforme.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: