Comments from bug 52154: ------- Additional Comments From rbs@maths.uq.edu.au 2001-04-17 14:37 ------- It just occurred to me that something was left out when jce2 initially implemented viewsource in html. I am mentioning it here for the record in case someone wants to fix it. It has to do with error reporting. The XML version outputs <error>...</error> [see CViewSourceHTML::WriteTagWithError()]. In the HTML version, this has to become <span class="error">...</span>.

The rule for that was in viewsouce.css for the error (others prefer blink :-) .error { background-color: #FFFFCC; font-weight: bold; }

There is another issue here. Currently mValidator is always null as far as I can tell. So we end up not doing any of the error reporting stuff anyway... I'll investigate this a bit.

Does the removal of the strict DTD have anything to do with this? I imagine we used that as the validator.... See bug 50070

The strict DTD wouldn't always report the errors correctly, so I don't think we should use it.

OK. Well, does the quirks DTD report errors? If so, I would be willing to try and hook up this error reporting again...

I hope not, because I strongly suspect it's concept of an error is different from what's an error according to the spec's. If we have error reporting it should be correct, and I doubt we could get anything close to that with any of the existing DTDs, and especially CNavDTD.

This is completely broken. Setting mValidator is easy, but does not make it work. I think the obsolete code can be savely removed. My fix for bug 57724 will include some syntax highlighting at the tokenizer level, but that is quite different from the old error reporting (will mark things such as unescaped ampersands, forgotten semicolons and attributes in end tags).

Andreas, do you want to morph this bug into "remove the error-reporting code"? And take it?

Do we all agree on removing this code?

I certainly agree, but Harish should have his say.

Since we don't have a DTD that could be used to report errors correctly ( unless someone is willing to implement an nsErrorsDTD...which I really doubt ) it makes sense to remove the unused code.

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 (you can query for this string to delete spam or retrieve the list of bugs I've moved)

This bug has been marked "future" because the original netscape engineer working on this is over-burdened. If you feel this is an error, that you or another known resource will be working on this bug,or if it blocks your work in some way -- please attach your concern to the bug for reconsideration.

It looks like there's very little left to rip out, might as well get this done.

This rips out some more unnecessary garbage.

Fix checked in.