Closed Bug 764310 Opened 12 years ago Closed 12 years ago

IonMonkey: Compile JSOP_DEFFUN

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla20

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

(Whiteboard: [ion:p2:fx18])

Attachments

(2 files, 2 obsolete files)

Part 1: Refactor JSOP_DEFFUN interpreter logic
(deleted), patch
bhackett1024
: review+
Details | Diff | Splinter Review
Part 2: Compile DEFFUN
(deleted), patch
bhackett1024
: review+
Details | Diff | Splinter Review
We probably don't need this for the initial release since we can still fallback to JM+TI, but JSOP_DEFFUN is pretty common, especially in global scripts - see for instance SS base64.
Whiteboard: [ion:p2:fx18]
Most of the work here we will also need for the baseline compiler, so taking.
Assignee: general → jdemooij
Status: NEW → ASSIGNED
Attached patch Part 1: Refactor JSOP_DEFFUN interpreter logic (obsolete) (deleted) — — Splinter Review
Attachment #695468 - Flags: review?(bhackett1024)
Attached patch Part 2: Compile DEFFUN (obsolete) (deleted) — — Splinter Review
DEFFUN is used for function statements in the global scope, so this will also help test coverage.
Attachment #695469 - Flags: review?(bhackett1024)
Attachment #695468 - Flags: review?(bhackett1024)
Attachment #695469 - Flags: review?(bhackett1024)
Attachment #695468 - Attachment is obsolete: true
Attachment #695473 - Flags: review?(bhackett1024)
Attached patch Part 2: Compile DEFFUN (deleted) — — Splinter Review
Attachment #695469 - Attachment is obsolete: true
Attachment #695474 - Flags: review?(bhackett1024)
Attachment #695473 - Flags: review?(bhackett1024) → review+
Attachment #695474 - Flags: review?(bhackett1024) → review+
Part 1: https://hg.mozilla.org/integration/mozilla-inbound/rev/671e04519d02
Whiteboard: [ion:p2:fx18] → [ion:p2:fx18][leave open]
Part 2: https://hg.mozilla.org/integration/mozilla-inbound/rev/88a218a4b5bf
Whiteboard: [ion:p2:fx18][leave open] → [ion:p2:fx18]
https://hg.mozilla.org/mozilla-central/rev/671e04519d02 https://hg.mozilla.org/mozilla-central/rev/88a218a4b5bf
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: