Comment on attachment 633090 [details] [diff] [review] patch I need to take care of a few edge cases...

This is part of the arrow panel redesign ? https://wiki.mozilla.org/Arrow_Panel_Redesign

Yes, it's part of that. I didn't know we had a feature page for this.

we likely also need this to properly have the downloads button as the last button in the toolbar, so adding a dep just to track that.

for information, are we going to reduce the size of the arrow on other themes too, or just winstripe?

All platforms eventually.

(In reply to Marco Bonardo [:mak] from comment #6) > for information, are we going to reduce the size of the arrow on other > themes too, or just winstripe? We need to do it for all of them. I would like for them to be roughly the same structurally. Even if the styling may vary slightly.

Comment on attachment 633176 [details] [diff] [review] patch v2 Review of attachment 633176 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, the arrow just needs a little tweaking: - Arrow border should be a little bit darker - Arrow needs to have a matching drop shadow - Edges need to be a little more crisp (currently kind of blurry) - The arrow border shouldn't overlap the panel border (creates two darker pixels) Getting those details right with SVG might be difficult. It might better to use a PNGs instead. I will attach a screenshot.

Adding shadow to the arrow makes this more complicated, since the panel would move down due to the shadow extending above the arrow tip. That's why the shadow is cut off at the top in the current PNGs, which looks pretty bad. Since the arrow shadow is going to be hardly visible at this opacity and size, I'd prefer just skipping it for now.

made the arrow border darker and crisper, removed the overlapping pixels, added a very subtle shadow on the sides (not the full shadow, as explained)

Comment on attachment 633479 [details] [diff] [review] patch v3 Review of attachment 633479 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thank you!

Can we implement this to Windows Basic / Windows Classic and other visual themes too? Coz now it is pretty generic for Windows

Sorry for OT, but will they receive animations? I was kinda hoping to see them implemented in this patch. :/