Closed
Bug 765038
Opened 13 years ago
Closed 13 years ago
The fix for bug 761890 broke clang builds in gfx/skia/src/sfnt/SkOTTable_head.h
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: jwatt, Assigned: nrc)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jwatt
:
review+
|
Details | Diff | Splinter Review |
gfx/skia/src/sfnt/SkOTTable_head.h:117:76: error: non-type template argument evaluates to -1, which cannot be narrowed to type 'uint16_t' (aka 'unsigned short')
[-Wc++11-narrowing]
SkPathEffect.cpp
((OnlyStronglyRTL, static_cast<SK_OT_SHORT>(SkTEndian_SwapBE16(-1))))
gfx/skia/src/sfnt/SkOTTable_head.h:118:72: error: non-type template argument evaluates to -2, which cannot be narrowed to type 'uint16_t' (aka 'unsigned short')
[-Wc++11-narrowing]
((StronglyRTL, static_cast<SK_OT_SHORT>(SkTEndian_SwapBE16(-2))))
Comment 1•13 years ago
|
||
Additional context (via IRC):
jwatt hit this while doing a local clobber build of mozilla-inbound, on Mac OS X, using clang.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → ncameron
Assignee | ||
Comment 2•13 years ago
|
||
builds with Visual Studio, hope this fixes the Clang issue
Attachment #633401 -
Flags: review?(jwatt)
Assignee | ||
Comment 3•13 years ago
|
||
Disclaimer: I'm pretty sure this is innocuous, but I haven't tried any testing at all.
Reporter | ||
Comment 4•13 years ago
|
||
Comment on attachment 633401 [details] [diff] [review]
patch
Looks fine to me.
I filed an upstream bug on this too, noting your patch here:
http://code.google.com/p/skia/issues/detail?id=649
Attachment #633401 -
Flags: review?(jwatt) → review+
Reporter | ||
Comment 5•13 years ago
|
||
Seems to work fine too.
I pushed this to m-i:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ec9d53ce65c
Thanks, nrc!
Target Milestone: --- → mozilla16
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•