I commented on the fact that Tara is called the Bugzilla "owner" on the web page and asked just what an owner of a piece of software is meant to be. I thought it was trying to get at "project leader" but Dave said it was more like "default assignee for the Bugzilla component", which had never occurred to me. It was not suprising to me therefore that the bug page uses the wording "assignee". However, inconsistently "owner" appears on editcomponents.cgi on the components table (editcomponents.cgi?product=XXX) and on the specific component form (editcomponents.cgi?product=XXX&component=YYY&action=edit). I'm not concerned with the schema, and I'm not sure about any other pages. So basically, we should make this consistent. I suggest assignee is a better term since it is less ambiguous, at least when used outside the context of Bugzilla like it was on the web page.

-> Bugzilla product, User Interface component, reassigning.

We are currently trying to wrap up Bugzilla 2.16. We are now close enough to release time that anything that wasn't already ranked at P1 isn't going to make the cut. Thus this is being retargetted at 2.18. If you strongly disagree with this retargetting, please comment, however, be aware that we only have about 2 weeks left to review and test anything at this point, and we intend to devote this time to the remaining bugs that were designated as release blockers.

The User Interface component now belongs to Gerv. Reassigning all UNCONFIRMED and NEW (but not ASSIGNED) bugs currently owned by Myk (the previous component owner) to Gerv.

Reassigning back to Myk. That stuff about Gerv taking over the User Interface component turned out to be short-lived. Please pardon our confusion, and I'm very sorry about the spam.

Unloved bugs targetted for 2.18 but untouched since 9-15-2003 are being retargeted to 2.20 If you plan to act on one immediately, go ahead and pull it back to 2.18.

<vladd> Well someone could say that justdave is the owner of all bugzilla bugs but they couldn't they said using the "assignee" word so I prefer assignee :) <LpSolit> I also prefer assignee <spidercrashed> assignee is better

Moreover, some users think that the owner of a bug is the one who submits it! "Owner" is very confusing.

Agreed. Owner is as problematic as auteur in film theory. Is it the scriptwriter, the director, or the editor? Assignee, although not as clear as "fixer" would be, at least lacks the ownership ambiguity.

This bug has so far only mentioned editcomponents.cgi. I'm guessing that the bug also includes describecomponents.cgi, and the various error messages which mention 'owner', yes? i.e. Bugzilla should no longer mention 'Owner' in relation to bugs/components, but should always say Assignee?

Comment on attachment 182400 [details] [diff] [review] "assignee" instead of "owner" (labels changed) Thanks for the patch! It's a good start. Just a couple things: >Index: template/en/default/admin/components/edit.html.tmpl >- <td valign="top"><label for="initialowner">Initial owner:</label></td> >+ <td valign="top"><label for="initialowner">Assignee:</label></td> This needs to be "Initial Assignee" here and in components/list.html.tmpl to clarify that the field represents the default value, not the permanent one. But since we're making changes, let's make this "Default Assignee" for consistency with reports/components.html.tmpl and because one can reset a bug to this assignee after having created the bug, so "initial" is not completely accurate. >Index: template/en/default/admin/components/list.html.tmpl >Index: template/en/default/reports/components.html.tmpl A grep through the template code shows that the word "owner" appears in many other places in the code besides these three templates, including list/edit-multiple.html.tmpl, list/list.html.tmpl, global/user-error.html.tmpl, and search/form.html.tmpl, among others. The fix for this bug should fix all these uses at once so that we can make the usage consistent.

Comment on attachment 185885 [details] [diff] [review] v2: full change. >- $err .= "The original owner of this bug does not have\n"; >+ $err .= "The original assignee of this bug does not have\n"; original assignee or default assignee? >- <th align="right"><label for="initialowner">Initial Owner:</label></th> >+ <th align="right"><label for="initialowner">Default Assignee:</label></th> Do we still want "initialowner" now that "owner" is banned? Why not "defaultassignee"? >- <td valign="top"><label for="initialowner">Initial owner:</label></td> >+ <td valign="top"><label for="initialowner">Default Assignee:</label></td> Same here... > [% IF updated_initialowner %] >- <p>Updated Initial Owner to: '[% initialowner FILTER html %]'.</p> >+ <p>Updated Default Assignee to: '[% initialowner FILTER html %]'.</p> > [% END %] ... and here... > [% responsibilityterms = { >- 'initialowner' => 'Initial Owner', >+ 'initialowner' => 'Default Assignee', > 'initialqacontact' => 'Initial QA Contact' > } > %] ... and here... > [% ELSIF error == "component_need_initialowner" %] > [% ELSIF error == "component_need_valid_initialowner" %] and here. > <label for="knob-reassignbycomponent"> >- Reassign [% terms.bugs %] to owner of selected component >+ Reassign [% terms.bugs %] to assignee of selected component Could I suggest "to default assignee of selected component" ?

Comment on attachment 185885 [details] [diff] [review] v2: full change. >Index: importxml.pl >@@ -531,13 +531,13 @@ for (my $k=1 ; $k <= $bugqty ; $k++) { >- $err .= "The original owner of this bug does not have\n"; >+ $err .= "The original assignee of this bug does not have\n"; s/orginal/previous/ ? (we're talking about import/move) > $err .= " an account here. Reassigning to the person who moved\n"; > $err .= " it here, $exporter.\n"; > if ( $bug_fields{'assigned_to'} ) { >- $err .= " Previous owner was $bug_fields{'assigned_to'}.\n"; >+ $err .= " Previous assignee was $bug_fields{'assigned_to'}.\n"; note that this text uses previous :). >@@ -556,7 +556,7 @@ for (my $k=1 ; $k <= $bugqty ; $k++) { > if ( ($changed_owner) && (!$resolution[0]) ) { > push (@values, SqlQuote("NEW")); > push (@query, "bug_status"); >- $err .= "Bug assigned to new owner, setting status to \"NEW\".\n"; >+ $err .= "Bug assigned to new assignee, setting status to \"NEW\".\n"; this is awkward. > $err .= " Previous status was \""; > $err .= (defined $bug_fields{'bug_status'})? > $bug_fields{'bug_status'}:"unknown"; >Index: quicksearchhack.html >@@ -123,9 +123,9 @@ for access speed): i'm not sure this change should me made: > <tr> > <td>&nbsp;</td> >- <td><b>@</b><i>owner</i></td> >+ <td><b>@</b><i>assignee</i></td> > <td><tt>assignedto</tt></td> >- <td><tt>assignee, owner</tt></td> >+ <td><tt>assignee</tt></td> > <td><a href="page.cgi?id=fields.html#assigned_to">Assignee</a> <i>("assigned_to")</i></td> >@@ -317,8 +317,8 @@ Examples for some useful abbreviations: in addition to not being sure if these changes should be made, i suspect they're not right (but i'm tired, it's been a long week, i could easily be wrong): >- <td><b>@</b><i>owner</i></td> >- <td><b>assignedto:</b><i>owner</i></td> >+ <td><b>@</b><i>assignee</i></td> >+ <td><b>assignedto:</b><i>assignee</i></td> >Index: template/en/default/admin/components/edit.html.tmpl >@@ -55,7 +55,7 @@ do we need to consider the the label for= and name mapping bits? >+ <td valign="top"><label for="initialowner">Default Assignee:</label></td> > name => "initialowner" >Index: template/en/default/admin/components/list.html.tmpl >@@ -65,7 +65,7 @@ > name => "initialowner" >Index: template/en/default/admin/components/updated.html.tmpl >@@ -54,7 +54,7 @@ > [% IF updated_initialowner %] >+ <p>Updated Default Assignee to: '[% initialowner FILTER html %]'.</p> > [% IF updated_initialqacontact %] perhaps changing initial to default (as a code change) should be done in another bug.... >Index: template/en/default/admin/users/confirm-delete.html.tmpl >@@ -57,7 +57,7 @@ > [% responsibilityterms = { >- 'initialowner' => 'Initial Owner', >+ 'initialowner' => 'Default Assignee', > 'initialqacontact' => 'Initial QA Contact' Should we change this to Default QA Contact? >Index: template/en/default/bug/create/create.html.tmpl >@@ -223,7 +223,7 @@ function set_assign_to() { >+ <noscript>(Leave blank to assign to default component assignee)</noscript> component's default assignee? >Index: template/en/default/global/user-error.html.tmpl >@@ -280,12 +280,12 @@ >+ You must use an existing [% terms.Bugzilla %] account as default assignee for the default assignee? >@@ -1089,7 +1089,7 @@ > [% title = "Can't Delete User Account" %] > The user you want to delete is set up for roles as initial [% terms.bug %] here initial really does need to change to default :) >- owner or QA contact for at least one component. >+ assignee or QA contact for at least one component. >Index: template/en/default/list/edit-multiple.html.tmpl >@@ -317,7 +317,7 @@ > <label for="knob-reassignbycomponent"> >+ Reassign [% terms.bugs %] to assignee of selected component default assignee > <th align="left">Default QA Contact</th> note that we sometimes call it default ... >Index: template/en/default/search/form.html.tmpl

Comment on attachment 185885 [details] [diff] [review] v2: full change. per my previous review and comments from timeless.

Comment on attachment 186225 [details] [diff] [review] v3: some fixes. >- $err .= "The original owner of this bug does not have\n"; >+ $err .= "The previous assignee of this bug does not have\n"; Keep "original". This bug is new, so the actual owner appears as the original one, relatively to our DB. > <td><tt>assignedto</tt></td> >- <td><tt>assignee, owner</tt></td> >+ <td><tt>assignee</tt></td> Nit: 'owner' is valid here too, see quicksearch.js line 118. Keep it (for backward compatibility). >- <td valign="top">Initial owner:</td> >+ <td valign="top">Default assignee:</td> If you replace "Initial owner" by "Default assignee", then you should also replace "Initial QA contact" by "Default QA contact", for consistency (else a user could ask: "what's the difference between initial and default?"). Moreover, "initial" is wrong in some way as the first assignee of a given bug is not necessarily the default one. So "default" definitely sounds better.

Comment on attachment 186232 [details] [diff] [review] v5: Missing some code changes. You missed a 'owner' in knob.html.tmpl. Moreover, about http://phpfi.com/65967 : --- Bugzilla/BugMail.pm 4 Apr 2005 21:09:17 -0000 1.39 +++ Bugzilla/BugMail.pm 14 Jun 2005 22:00:44 -0000 @@ -110,7 +110,7 @@ END # cmd line interface. Should clean this up at some point. # # args: bug_id, and an optional hash ref which may have keys for: -# changer, owner, qa, reporter, cc +# changer, assignee, qa, reporter, cc The key name is 'owner', not 'assignee'. So I would keep it as is here (to avoid confusion). --- template/en/default/bug/knob.html.tmpl 9 May 2005 22:49:41 -0000 1.17 +++ template/en/default/bug/knob.html.tmpl 14 Jun 2005 22:00:54 -0000 @@ -118,7 +118,7 @@ <input type="radio" id="knob-reassign-cmp" name="knob" value="reassignbycomponent"> <label for="knob-reassign-cmp"> - Reassign [% terms.bug %] to owner + Reassign [% terms.bug %] [% " and QA contact" IF Param('useqacontact') %] of selected component </label> Your sentence here does mean anything => Reassign bug *to default assignee* I will do another 'grep' as soon as you have updated this patch (to decrease my output when using grep).

Comment on attachment 186317 [details] [diff] [review] v6: some changes. argh... we are *so* close. You missed some changes in three files only: defparams.pl: line 814: owner -> default assignee docs/xml/administration.xml: line 196: owner -> assignee line 583: owner -> default assignee line 584: owner -> default assignee line 877: owner -> assignee docs/xml/using.xml: line 490: owner -> assignee line 493: owners -> assignees line 495: owners -> assignees Moreover, there are two 'an default' which should be 'a default': contrib/bugmail_help.html, line 115 template/en/default/global/user-error.html.tmpl, line 284

Comment on attachment 186472 [details] [diff] [review] v7: last one? r=LpSolit

Checking in buglist.cgi; /cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v <-- buglist.cgi new revision: 1.294; previous revision: 1.293 done Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 1.406; previous revision: 1.405 done Checking in defparams.pl; /cvsroot/mozilla/webtools/bugzilla/defparams.pl,v <-- defparams.pl new revision: 1.159; previous revision: 1.158 done Checking in editusers.cgi; /cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v <-- editusers.cgi new revision: 1.89; previous revision: 1.88 done Checking in editwhines.cgi; /cvsroot/mozilla/webtools/bugzilla/editwhines.cgi,v <-- editwhines.cgi new revision: 1.6; previous revision: 1.5 done Checking in importxml.pl; /cvsroot/mozilla/webtools/bugzilla/importxml.pl,v <-- importxml.pl new revision: 1.44; previous revision: 1.43 done Checking in process_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi new revision: 1.259; previous revision: 1.258 done Checking in quicksearchhack.html; /cvsroot/mozilla/webtools/bugzilla/quicksearchhack.html,v <-- quicksearchhack.html new revision: 1.6; previous revision: 1.5 done Checking in contrib/bugmail_help.html; /cvsroot/mozilla/webtools/bugzilla/contrib/bugmail_help.html,v <-- bugmail_help.html new revision: 1.2; previous revision: 1.1 done Checking in docs/xml/administration.xml; /cvsroot/mozilla/webtools/bugzilla/docs/xml/administration.xml,v <-- administration.xml new revision: 1.50; previous revision: 1.49 done Checking in docs/xml/customization.xml; /cvsroot/mozilla/webtools/bugzilla/docs/xml/customization.xml,v <-- customization.xml new revision: 1.19; previous revision: 1.18 done Checking in docs/xml/using.xml; /cvsroot/mozilla/webtools/bugzilla/docs/xml/using.xml,v <-- using.xml new revision: 1.30; previous revision: 1.29 done Checking in template/en/default/account/prefs/email.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/email.html.tmpl,v <-- email.html.tmpl new revision: 1.21; previous revision: 1.20 done Checking in template/en/default/admin/components/confirm-delete.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/components/confirm-delete.html.tmpl,v <-- confirm-delete.html.tmpl new revision: 1.3; previous revision: 1.2 done Checking in template/en/default/admin/components/create.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/components/create.html.tmpl,v <-- create.html.tmpl new revision: 1.3; previous revision: 1.2 done Checking in template/en/default/admin/components/edit.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/components/edit.html.tmpl,v <-- edit.html.tmpl new revision: 1.4; previous revision: 1.3 done Checking in template/en/default/admin/components/list.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/components/list.html.tmpl,v <-- list.html.tmpl new revision: 1.2; previous revision: 1.1 done Checking in template/en/default/admin/components/updated.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/components/updated.html.tmpl,v <-- updated.html.tmpl new revision: 1.2; previous revision: 1.1 done Checking in template/en/default/admin/users/confirm-delete.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/confirm-delete.html.tmpl,v <-- confirm-delete.html.tmpl new revision: 1.3; previous revision: 1.2 done Checking in template/en/default/bug/knob.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/knob.html.tmpl,v <-- knob.html.tmpl new revision: 1.18; previous revision: 1.17 done Checking in template/en/default/bug/create/create.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v <-- create.html.tmpl new revision: 1.51; previous revision: 1.50 done Checking in template/en/default/global/user-error.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v <-- user-error.html.tmpl new revision: 1.112; previous revision: 1.111 done Checking in template/en/default/list/edit-multiple.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/list/edit-multiple.html.tmpl,v <-- edit-multiple.html.tmpl new revision: 1.26; previous revision: 1.25 done Checking in template/en/default/list/list.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list.html.tmpl,v <-- list.html.tmpl new revision: 1.37; previous revision: 1.36 done Checking in template/en/default/reports/components.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/components.html.tmpl,v <-- components.html.tmpl new revision: 1.9; previous revision: 1.8 done Checking in template/en/default/search/form.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/search/form.html.tmpl,v <-- form.html.tmpl new revision: 1.32; previous revision: 1.31 done