Closed
Bug 766577
Opened 13 years ago
Closed 12 years ago
fix "octal literals and octal escape sequences are deprecated" in c-c
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 16.0
People
(Reporter: Irving, Assigned: aceman)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
(deleted),
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #572890 +++
Since bug 514559, octal literals and octal escape sequences are deprecated in strict mode, resulting in warnings when starting Thunderbird (and possibly SeaMonkey)
JavaScript warning: chrome://messenger/content/folderPane.js, line 205: octal literals and octal escape sequences are deprecated
JavaScript warning: chrome://messenger/content/folderPane.js, line 205: octal literals and octal escape sequences are deprecated
JavaScript warning: chrome://messenger/content/folderPane.js, line 205: octal literals and octal escape sequences are deprecated
JavaScript warning: chrome://messenger/content/mailWindowOverlay.js, line 1386: octal literals and octal escape sequences are deprecated
While my most recent test run didn't give me warnings for these files, there are also octal literals in /mail/components/search/SpotlightIntegration.js and /mail/components/search/content/searchCommon.js (see https://bugzilla.mozilla.org/show_bug.cgi?id=670566#c55)
Reporter | ||
Updated•13 years ago
|
Assignee: nobody → acelists
Status: NEW → ASSIGNED
All occurences I could find with a grep regex (/addressbook/* is already handled in a separate bug).
Does Seamonkey also want a global patch for all files?
Attachment #635452 -
Flags: review?(mconley)
Attachment #635452 -
Flags: feedback?(iann_bugzilla)
Comment 3•13 years ago
|
||
> Does Seamonkey also want a global patch for all files?
But of course!!
Untested...
Attachment #635832 -
Flags: review?(iann_bugzilla)
Attachment #635452 -
Flags: feedback?(iann_bugzilla)
Comment on attachment 635832 [details] [diff] [review]
patch for Seamonkey
Not sure if this is the best way or not, Neil might though.
Attachment #635832 -
Flags: review?(iann_bugzilla) → review?(neil)
Comment 6•12 years ago
|
||
Comment on attachment 635832 [details] [diff] [review]
patch for Seamonkey
>- foStream.init(file, 0x02 | 0x08 | 0x20, 0666, 0);
>+ foStream.init(file, 0x02 | 0x08 | 0x20, parseInt("0666", 8), 0);
In theory we could use -1 here instead (it is special-cased as 0664 in this one function).
Attachment #635832 -
Flags: review?(neil) → review+
Comment 7•12 years ago
|
||
Comment on attachment 635452 [details] [diff] [review]
patch for TB
Review of attachment 635452 [details] [diff] [review]:
-----------------------------------------------------------------
This looks good to me too. Thanks for the cleanup, aceman!
Attachment #635452 -
Flags: review?(mconley) → review+
(In reply to neil@parkwaycc.co.uk from comment #6)
> Comment on attachment 635832 [details] [diff] [review]
> patch for Seamonkey
>
> >- foStream.init(file, 0x02 | 0x08 | 0x20, 0666, 0);
> >+ foStream.init(file, 0x02 | 0x08 | 0x20, parseInt("0666", 8), 0);
> In theory we could use -1 here instead (it is special-cased as 0664 in this
> one function).
But the original permissions were 0666, so I didn't want to change them (even though they are probably unwanted to be world writable). The respestive module owners should fix the logic (perms) in their own patches.
Keywords: checkin-needed
Whiteboard: [checkin both patches]
Comment 9•12 years ago
|
||
https://hg.mozilla.org/comm-central/rev/05b0aa51099a
https://hg.mozilla.org/comm-central/rev/a98a0a64fc02
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [checkin both patches]
Target Milestone: --- → Thunderbird 16.0
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•