Closed
Bug 766966
Opened 12 years ago
Closed 12 years ago
Change Reader Mode menu item from "Font" to "Text"
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 16
People
(Reporter: ibarlow, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
||
Comment 1•12 years ago
|
||
Attachment #635681 -
Flags: review?(mark.finkle)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 635681 [details] [diff] [review]
Change "Font" to "Text" in Reader UI
>diff --git a/mobile/android/locales/en-US/chrome/aboutReader.properties b/mobile/android/locales/en-US/chrome/aboutReader.properties
>-aboutReader.fontTitle=Font
>+aboutReader.fontTitle=Text
You'll need to change the entity name too, because some locales have already translated this string:
http://mxr.mozilla.org/l10n-central/search?string=aboutReader.fontTitle
aboutReader.textTitle=Text
or
aboutReader.fontTitle2=Text
Everyone wishes we didn't need to do this and L10N has future tools that will allow us to not do it, but for now, we need to do it.
r- since the patch we get a little bigger
Attachment #635681 -
Flags: review?(mark.finkle) → review-
|
|
||
Comment 3•12 years ago
|
||
Attachment #635760 -
Flags: review?(mark.finkle)
|
|
||
Updated•12 years ago
|
Attachment #635681 -
Attachment is obsolete: true
|
|
||
Updated•12 years ago
|
Attachment #635760 -
Flags: review?(mark.finkle) → review+
|
|
||
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
|
||
Comment 6•12 years ago
|
||
Verified fixed on:
-build: Firefox for Android 20.0b5, Firefox for Android 21.0a2 (2013-03-14) and Firefox for Android 22.0a1(2013-03-15)
-device: Samsung Galaxy Nexus
-OS: Android 4.1.1
Status: RESOLVED → VERIFIED
|
Assignee | |
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•