Closed
Bug 76714
Opened 24 years ago
Closed 23 years ago
incorrectly nested FORM and TABLE tags in command menu
Categories
(Bugzilla :: User Interface, defect, P1)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: myk, Assigned: myk)
Details
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
The command menu that appears at the bottom of most Bugzilla pages contains
incorrectly nested </form> and </table> tags as well as extraneous <tr> and
</tr> tags. This bug may cause form data to be lost when returning to a cached
Bugzilla page (bug 74639).
Assignee | ||
Comment 2•24 years ago
|
||
Assignee | ||
Comment 3•24 years ago
|
||
I ran htmltidy on the results of viewing bug 74639 before and after the patch
was applied to the Bugzilla installation running on my workstation:
-----
bash$ tidy -errors before-the-patch.html
...
line 185 column 542 - Warning: discarding unexpected </tr>
...
line 187 column 5 - Warning: discarding unexpected </form>
line 188 column 1 - Warning: trimming empty <tr>
line 189 column 1 - Warning: missing </form> before </td>
...
bash$ tidy -errors after-the-patch.html
...
[no warnings about these problems]
...
-----
Note: When testing this patch using Mozilla, reload the page from scratch after
applying the patch to make sure your results aren't skewed by potential cache bugs.
Assignee: tara → myk
Status: ASSIGNED → NEW
Updated•24 years ago
|
Target Milestone: --- → Bugzilla 2.16
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Updated•23 years ago
|
Priority: -- → P1
Updated•23 years ago
|
Component: Bugzilla → User Interface
Product: Webtools → Bugzilla
Version: Bugzilla 2.11 → 2.10
Comment 5•23 years ago
|
||
r=gerv. Patch has rotted. New version coming up.
Gerv
Comment 6•23 years ago
|
||
Assignee | ||
Comment 7•23 years ago
|
||
Comment on attachment 51480 [details] [diff] [review]
Patch v.2
This patch works on my test installation, and htmltidy reports no nesting errors
after it is applied. r=myk, no second review needed.
Attachment #51480 -
Flags: review+
Assignee | ||
Comment 8•23 years ago
|
||
Checked-in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•