Closed
Bug 767776
Opened 13 years ago
Closed 12 years ago
Port |Bug 753205 - bookmarks import ignores separators| to SeaMonkey. ("TypeError: redeclaration of const FILENAME_BOOKMARKS_HTML")
Categories
(SeaMonkey :: Testing Infrastructure, defect, P2)
SeaMonkey
Testing Infrastructure
Tracking
(seamonkey2.11 wontfix, seamonkey2.12 wontfix)
VERIFIED
FIXED
seamonkey2.13
People
(Reporter: Callek, Assigned: sgautherie)
References
Details
(Keywords: regression, Whiteboard: [perma-orange])
Attachments
(2 files)
(deleted),
patch
|
iannbugzilla
:
review+
Callek
:
approval-comm-aurora-
Callek
:
approval-comm-beta-
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #753205 +++
(In reply to Marco Bonardo [:mak] from bug 739041 comment #35)
> (In reply to Serge Gautherie (:sgautherie) from bug 739041 comment #34)
> > Marco, can you confirm that it is expected that the separator is not
> > imported (anymore?)?
>
> The separators should be imported afaik, it's their names we don't import
> anymore, but this one doesn't even have a name...
> The firefox bookmarks preplaces doesn't have a separator, so there may even
> be an actual regression here, indeed the old code had an handleSeparator,
> the new code is missing it :(
Bug 753205 broke a bunch of our places tests (Such as test_384370.js), due in part to http://hg.mozilla.org/mozilla-central/diff/904364bcee0e/toolkit/components/places/tests/head_common.js
e.g.
e:/builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/head_bookmarks.js -> file:///e:/builds/slave/test/build/xpcshell/tests/toolkit/components/places/tests/head_common.js:408: TypeError: redeclaration of const FILENAME_BOOKMARKS_HTML
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #639123 -
Flags: review?(iann_bugzilla)
Attachment #639123 -
Flags: approval-comm-beta?
Attachment #639123 -
Flags: approval-comm-aurora?
Assignee | ||
Updated•12 years ago
|
status-seamonkey2.11:
--- → affected
status-seamonkey2.12:
--- → affected
Summary: bookmarks import ignores separators. ([SeaMonkey] "test_bookmarks_html.js | 3 == 4") → Port |Bug 753205 - bookmarks import ignores separators| to SeaMonkey. ("TypeError: redeclaration of const FILENAME_BOOKMARKS_HTML")
Target Milestone: --- → seamonkey2.13
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #639125 -
Flags: review?(mak77)
Attachment #639123 -
Flags: review?(iann_bugzilla) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 639123 [details] [diff] [review]
(Av1) Port |Bug 753205 - bookmarks import ignores separators| to SeaMonkey
[Checked in: Comment 3]
http://hg.mozilla.org/comm-central/rev/881420f9c131
Attachment #639123 -
Attachment description: (Av1) Port |Bug 753205 - bookmarks import ignores separators| to SeaMonkey → (Av1) Port |Bug 753205 - bookmarks import ignores separators| to SeaMonkey
[Checked in: Comment 3]
Assignee | ||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Assignee | ||
Comment 4•12 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1341688685.1341690194.4905.gz
WINNT 5.2 comm-central-trunk debug test xpcshell on 2012/07/07 12:18:05
V.Fixed.
NB: There is a "test_browserGlue_smartBookmarks.js | 6 == 5" error, but ftb I assume it is not this bug.
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 5•12 years ago
|
||
Comment on attachment 639123 [details] [diff] [review]
(Av1) Port |Bug 753205 - bookmarks import ignores separators| to SeaMonkey
[Checked in: Comment 3]
Test only, not approving
Attachment #639123 -
Flags: approval-comm-beta?
Attachment #639123 -
Flags: approval-comm-beta-
Attachment #639123 -
Flags: approval-comm-aurora?
Attachment #639123 -
Flags: approval-comm-aurora-
Assignee | ||
Updated•12 years ago
|
Whiteboard: [perma-orange]
Updated•12 years ago
|
Attachment #639125 -
Flags: review?(mak77) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•