Closed Bug 767956 Opened 12 years ago Closed 12 years ago

Reader Mode: Readability detection code needs to be improved

Categories

(Firefox for Android Graveyard :: Reader View, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox16-, fennec16+)

RESOLVED FIXED
Tracking Status
firefox16 - ---
fennec 16+ ---

People

(Reporter: pretzer, Unassigned)

References

Details

The code to detect whether the reader icon should be displayed in the awesomebar produces some false positives at the moment, which causes the icon to be displayed on sites where it doesn't make much sense. For example the icon is currently displayed on Bugzilla bug lists and individual bug pages. When trying to invoke reader mode on those pages the loading fails with " Failed to load article from page".
tracking-fennec: --- → ?
Version: unspecified → Trunk
tracking-fennec: ? → 16+
Pinged UX/product to help make a final decision on what would be required to ship this feature (and if this bug specifically would be required).
(In reply to Alex Keybl [:akeybl] from comment #3) > Pinged UX/product to help make a final decision on what would be required to > ship this feature (and if this bug specifically would be required). FWIW, I think this bug should definitely be fixed for the final release. Right now, the readability check is a bit unreliable which means Fennec is often showing the reader mode option when it shouldn't.
Component: General → Reader Mode
Bug 779796 should eliminate all false positives, fixing this bug.
Depends on: 779796
Moving tracking for 16 over to bug 779796 then, as per comment 5.
Should now be fixed in Nightly.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
While the loading doesn't fail with "Failed to load article from page" anymore, the reader mode icon is still presented on bug-pages and bug-lists for example, which seem to be false positives for me as stated in comment 0. Or was the solution here to simply consider every webpage to be "readable" now?
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
(In reply to Peter Retzer (:pretzer) from comment #8) > While the loading doesn't fail with "Failed to load article from page" > anymore, the reader mode icon is still presented on bug-pages and bug-lists > for example, which seem to be false positives for me as stated in comment 0. > Or was the solution here to simply consider every webpage to be "readable" > now? This is a different bug - see bug 782285.
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.