Xlib-toolkit based Mozilla build from 2001-04-17 CVS snapshot does not render images correctly - and at the same time it spamms the log with "nsImageXlib::DrawToImage not yet implemented: 'Not Reached'" messages. It looks that the not-yet-implemented function nsImageXlib::DrawToImage() is responsible for this problem... ;-( CC:'ing pavlov as he wrong the code for GTK+-toolkit and dbaron@fas.harvard.edu for the partial implementation for Xlib-toolkit...

I tried to actually fix that implementation, and I'll attach what I've done so far. However, it doesn't actually help at all...

->blizzard

Uhm... after looking twice on that code... What about creating a XImage from incoming nsIImage, run XSubImage() (and care about alpha stuff if required) and pass contents of resulting XImage back to destination... blizzard.... do you see any problems with that idea ?

There are some fixes for image drawing attached to bug #66082 as part of xlib gc-cache update.

Fix in bug 66082

Now that bug 66082 is in, here are additional fixes to sync nsImageXlib with the GTK version and fix nearly *all* image related problems :)

gisburn: can you give this a couple tests on your build and see how it works? This should fix some 1x1 scaled transparent gif issues and also a couple typos I had in bug 66082

Lates patch looks good and works ok. Patch is just collection of gtk changes ported to xlib. r=tomilepp

Sorry about this, but I have noticed you gave out sr= on some other Xlib related stuff, so I thought I would send this your way. This is mostly a cut & paste from ImageGTK to bring it in sync, plus a couple typos fixes from my last patch.

rs=darin

ok, will check in

fix checked in, thanks

Looks good here with latest xlib-toolkit build