Closed
Bug 768388
Opened 12 years ago
Closed 11 years ago
Support "hidden" preference for all types for simple-prefs
Categories
(Add-on SDK Graveyard :: General, enhancement, P3)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: JanecekPetr, Assigned: evold)
References
Details
Attachments
(2 files)
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:14.0) Gecko/20100101 Firefox/14.0
Build ID: 20120624012213
Steps to reproduce:
Every simple-prefs type should have a preference "hidden" (defaults to false) that, when set, would not show the preference in the addons manager.
Useful for providing advanced / possibly dangerous preferences via about:config for advanced users. Or for internal use when there's need to save something as a pref (say there's a control setting something invisibly) to be synced across browsers.
You can already sort of do that with the low-level preferences-service module: https://addons.mozilla.org/en-US/developers/docs/sdk/latest/packages/api-utils/preferences-service.html
Would using that be acceptable for what you want to do?
Reporter | ||
Comment 2•12 years ago
|
||
Absolutely, that's the stuff I needed. It's just so confusing that it's not on the same place :). Thank you, I guess this can be closed.
Maybe we can add a bit to simple-prefs documentation pointing out that the preferences-service can be used to get more low-level control over preferences.
Status: UNCONFIRMED → NEW
Component: General → Documentation
Ever confirmed: true
Comment 4•12 years ago
|
||
Should we keep this bug open, and raise another to update the doc? This sounds like a reasonable feature to ask for in the high level API, and if we make this just a documentation bug, we'll lose that.
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to Will Bamberg [:wbamberg] from comment #4)
> Should we keep this bug open, and raise another to update the doc? This
> sounds like a reasonable feature to ask for in the high level API, and if we
> make this just a documentation bug, we'll lose that.
A 'hidden' type sounds reasonable for the preference sync'ing use case. It would also avoid the need for users to set prefs in two places.
Severity: normal → enhancement
Status: NEW → ASSIGNED
Component: Documentation → General
Priority: -- → P3
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Wes Kocher (:KWierso) from comment #3)
> Maybe we can add a bit to simple-prefs documentation pointing out that the
> preferences-service can be used to get more low-level control over
> preferences.
Let's make another bug for that.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → evold
Assignee | ||
Updated•12 years ago
|
Blocks: sdk/simple-prefs
Assignee | ||
Updated•12 years ago
|
Assignee: evold → nobody
Whiteboard: [good first bug]
Assignee | ||
Comment 7•11 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•11 years ago
|
Attachment #750530 -
Flags: review?(zer0)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → evold
Whiteboard: [good first bug]
Assignee | ||
Comment 8•11 years ago
|
||
Comment on attachment 750530 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1000
This pull request is now 2 months old, I'm giving it to someone else.
Attachment #750530 -
Flags: review?(zer0) → review?(rFobic)
Comment 9•11 years ago
|
||
Comment on attachment 750530 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1000
Rejecting in order to make hidden be a separate from type as agreed on IRC.
Attachment #750530 -
Flags: review?(rFobic) → review-
Assignee | ||
Comment 10•11 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•11 years ago
|
Attachment #776791 -
Flags: review?(rFobic)
Updated•11 years ago
|
Attachment #776791 -
Flags: review?(rFobic) → review+
Comment 11•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/cb5d206f778d80eb6c175d2829cca2eb7107d3c3
Bug 768388: support hidden pref type
https://github.com/mozilla/addon-sdk/commit/2a40cf47944fb9e1b45ec019a5495b86d39d0233
Merge pull request #1114 from erikvold/768388v2
Bug 768388: support hidden pref type r=@gozala
Depends on: 897683
I'm going through the list of open bugs that github robot has commented in. Is this bug fixed, Irakli?
Flags: needinfo?(rFobic)
Comment 13•11 years ago
|
||
(In reply to Wes Kocher (:KWierso) from comment #12)
> I'm going through the list of open bugs that github robot has commented in.
> Is this bug fixed, Irakli?
It seems merged so I guess it is fixed.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: needinfo?(rFobic)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•