Closed
Bug 768506
Opened 12 years ago
Closed 9 years ago
Toolbar buttons should have a min-height
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1208715
People
(Reporter: johan.charlez, Unassigned)
References
Details
(Whiteboard: [Australis:P-])
Attachments
(2 files)
screenshot 1
A min-width should keep buttons added by extensions in check.
The "List all tabs" button could use a min-width as well.
See 'screenshot 1' for the extension case (chatzilla).
See 'screenshot 2' for the "List all tabs" case.
|
||
Comment 3•12 years ago
|
||
The screenshots attached show more of a need for a min-height to me.
That being said, I'm not sure if we should do this or not.
Summary: Australis Toolbar buttons should have a min-width. → Australis Toolbar buttons should have a min-width and min-height
(In reply to Jared Wein [:jaws] from comment #3)
> The screenshots attached show more of a need for a min-height to me.
You are quite right, I have no idea why I wrote width rather than height.
Fixed the summary.
Summary: Australis Toolbar buttons should have a min-width and min-height → Australis Toolbar buttons should have a min-height
|
||
Updated•11 years ago
|
|
||
Updated•11 years ago
|
Summary: Australis Toolbar buttons should have a min-height → Toolbar buttons should have a min-height
Whiteboard: [Australis:P5]
|
|
||
Updated•11 years ago
|
Whiteboard: [Australis:P5] → [Australis:P3]
|
||
Comment 5•11 years ago
|
||
(In reply to Jared Wein [:jaws] from comment #3)
> The screenshots attached show more of a need for a min-height to me.
>
> That being said, I'm not sure if we should do this or not.
I think it makes sense to have minimum (yet overridable) dimensions on these toolbarbuttons, for consistency. What are the reasons to not do this?
Flags: needinfo?(jaws)
|
|
||
Comment 6•11 years ago
|
||
(In reply to Mike Conley (:mconley) from comment #5)
> (In reply to Jared Wein [:jaws] from comment #3)
> > The screenshots attached show more of a need for a min-height to me.
> >
> > That being said, I'm not sure if we should do this or not.
>
> I think it makes sense to have minimum (yet overridable) dimensions on these
> toolbarbuttons, for consistency. What are the reasons to not do this?
Add-on compat. We can make it overridable, but some add-ons won't update to override the styling. Although I don't know how many add-ons *want* it to be shorter than the default.
Flags: needinfo?(jaws)
|
||
Comment 7•11 years ago
|
||
We shipped this button styling long ago -- adding a min-height seems unrelated to all the other Australis work currently happening.
Whiteboard: [Australis:P3] → [Australis:P-]
|
||
Comment 8•9 years ago
|
||
This was implemented in bug 1208715.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•