Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]] Reporter
	Description • 12 years ago

SecReview tracking bug
Actions regarding the review of the dependent bug should be tracked here.

	Lawrence Mandel [:lmandel] (use needinfo)
	Comment 1 • 12 years ago

Curtis - We're waiting on some UX love for about:telemetry but otherwise it's pretty much ready to land. What information do you need in order to proceed with the review and when can we get this on the schedule?

	Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]] Reporter
	Comment 2 • 12 years ago

This is going to be an individual review by Simon, not a team review. So this is more of a code level review. 
Is this a k9o or basecamp item?
What release are you all targeting?

Other than that just work with Simon so he can get this properly prioritized in his stack of work

	Lawrence Mandel [:lmandel] (use needinfo)
	Comment 3 • 12 years ago

This work does not block any of the Mozilla priority releases (Basecamp, k9o, etc.). Integrating about:telemetry in Firefox is the last privacy requirement for Telemetry. 

This is low priority but I *hope* won't take very long to review.

	Simon Bennetts [:psiinon] Assignee
	Comment 4 • 12 years ago

When would be a good time to have a chat about this?
Sent an email a couple of days ago but had no reply yet :)

	Simon Bennetts [:psiinon] Assignee
	Comment 5 • 12 years ago

Found this blog post: http://blog.mozilla.org/tglek/2011/05/13/firefox-telemetry/
And had a look at the add-on https://addons.mozilla.org/en-US/firefox/addon/abouttelemetry/

Anything else I should look at?

	Lawrence Mandel [:lmandel] (use needinfo)
	Comment 6 • 12 years ago

(In reply to sbennetts@mozilla.com from comment #4)
> When would be a good time to have a chat about this?
> Sent an email a couple of days ago but had no reply yet :)

Blame the slow reply on the Canada day weekend and my desire to spend as much time as possible water skiing and on the beach.

Vlad and I are both based in Toronto (ET). I'm available 10am-12pm ET pretty much every day.

(In reply to sbennetts@mozilla.com from comment #5)
> Found this blog post:
> http://blog.mozilla.org/tglek/2011/05/13/firefox-telemetry/
> And had a look at the add-on
> https://addons.mozilla.org/en-US/firefox/addon/abouttelemetry/
> 
> Anything else I should look at?

With those two references you should have a good idea of the what and why of about:telemetry. The patch on bug 661881 contains a different version of about:telemetry with some cleanup. Likely worth taking a look there as well. (Vlad, is there a try build with the integrated about:telemetry?)

	Simon Bennetts [:psiinon] Assignee
	Comment 7 • 12 years ago

What part of Firefox is this dev part of?
Just wondering which section of this page: https://wiki.mozilla.org/Security/Reviews I should file it under.
No problem creating new sections as required :)

	Lawrence Mandel [:lmandel] (use needinfo)
	Comment 8 • 12 years ago

(In reply to sbennetts@mozilla.com from comment #7)
> What part of Firefox is this dev part of?
> Just wondering which section of this page:
> https://wiki.mozilla.org/Security/Reviews I should file it under.
> No problem creating new sections as required :)

about:telemetry is part of Firefox itself.

	Simon Bennetts [:psiinon] Assignee
	Comment 9 • 12 years ago

Have you had a chance to create a test build I can try out?

	Vladan Djeric (:vladan)
	Comment 10 • 12 years ago

(In reply to sbennetts@mozilla.com from comment #9)
> Have you had a chance to create a test build I can try out?

Test build here: https://tbpl.mozilla.org/?tree=Try&rev=d90543833981

	Simon Bennetts [:psiinon] Assignee
	Comment 11 • 12 years ago

Review completed.

https://wiki.mozilla.org/Security/Reviews/AboutTelemetry