Closed
Bug 769400
Opened 12 years ago
Closed 12 years ago
Don't allow suspending the browser when downloading a file
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bbondy, Assigned: bbondy)
References
Details
(Whiteboard: [metro-mvp][LOE:1][metro-it2][completed-elm])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
Downloads currently fail if you navigate away from the Metro browser.
Leverage either the background tasks API or the PowerCreateRequest, PowerSetRequest, and PowerClearRequest functions (as documented in the Power Availability Requests whitepaper) in order to allow downloads.
Assignee | ||
Updated•12 years ago
|
Assignee: netzen → nobody
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → netzen
Whiteboard: [metro-mvp][LOE:1][metro-it2]
Assignee | ||
Comment 2•12 years ago
|
||
Works nicely, once downloads are done it allows the process suspend to happen
Attachment #693981 -
Flags: review?(jmathies)
Assignee | ||
Comment 3•12 years ago
|
||
if (!powerCreateRequest)
- return FALSE;
+ return INVALID_HANDLE_VALUE;
Attachment #693981 -
Attachment is obsolete: true
Attachment #693981 -
Flags: review?(jmathies)
Attachment #693985 -
Flags: review?(jmathies)
Comment 4•12 years ago
|
||
Comment on attachment 693981 [details] [diff] [review]
Patch v1
Review of attachment 693981 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me!
::: widget/windows/winrt/MetroAppShell.cpp
@@ +210,5 @@
> + static HMODULE kernel32 = GetModuleHandleW(L"kernel32.dll");
> + static PowerCreateRequestPtr powerCreateRequest =
> + (PowerCreateRequestPtr)GetProcAddress(kernel32, "PowerCreateRequest");
> + if (!powerCreateRequest)
> + return FALSE;
nit - NULL seems more appropriate here.
Updated•12 years ago
|
Attachment #693985 -
Flags: review?(jmathies) → review+
Comment 5•12 years ago
|
||
(In reply to Brian R. Bondy [:bbondy] from comment #3)
> Created attachment 693985 [details] [diff] [review]
> Patch v2.
>
> if (!powerCreateRequest)
> - return FALSE;
> + return INVALID_HANDLE_VALUE;
That's even better!
Assignee | ||
Comment 6•12 years ago
|
||
Whiteboard: [metro-mvp][LOE:1][metro-it2] → [metro-mvp][LOE:1][metro-it2][completed-elm]
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Comment 7•12 years ago
|
||
This will be migrated in the elm -> m-c migration. Resolving.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•