Closed
Bug 769421
Opened 12 years ago
Closed 12 years ago
Make carrier stores work
Categories
(Marketplace Graveyard :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
2012-08-09
People
(Reporter: clouserw, Assigned: kumar)
References
Details
https://telefonica.marketplace.mozilla.org/en-US/ exists. This bug is for:
1) Make logins work
2) Grep for SITE_URL everywhere and turn it into a function that returns the right thing
3) Give us a STOREFRONT variable or function or something that will let us do if()s off the hostname if we have to in the future
Assignee | ||
Comment 1•12 years ago
|
||
I added middleware to detect a full URL based on HTTP_HOST. Eventually we should probably replace all instances of SITE_URL with this but for starters I just did browser ID so that logins will work on the telefonica subdomain.
https://github.com/mozilla/zamboni/commit/89fb4d9ed48de18784ba07006aa132af037d1ee1
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 2•12 years ago
|
||
This change breaks local browser ID logins. Add this to local settings to fix it:
SITE_URL_OVERRIDE = SITE_URL
In local settings, SITE_URL needs to be 'http://localhost:8000' or whatever you started the server with.
Assignee | ||
Comment 3•12 years ago
|
||
the massive SITE_URL fix will happen in bug 770641
Comment 4•12 years ago
|
||
Logging in doesn't work
STR:
1. Tester is not logged in
2. Go to https://telefonica-marketplace-dev.allizom.org
3. Click on 'Submit an app'
4. Log in using your browserID credentials
observed behavior:
https://telefonica-marketplace-dev.allizom.org/en-US/login?to=/en-US/developers/submit/app/ loads and log in fails with "You must log in to access that page." message.
screencast: http://screencast.com/t/h0dGdPd2xU
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•12 years ago
|
||
There are a lot of problems with the subdomain approach so I'm reverting all of this until someone convinces me that we really need them.
https://github.com/mozilla/zamboni/commit/fb788fea0b990c1258696ecde4ae1946b6ad6e96
https://github.com/mozilla/zamboni/commit/9dd743861babdd14119e9bff5249fad69b9c4574
Reporter | ||
Comment 6•12 years ago
|
||
Changing bug to be about carrier stores rather than subdomains.
Status: REOPENED → NEW
Summary: Make carrier subdomains work → Make carrier stores work
Reporter | ||
Updated•12 years ago
|
Target Milestone: 2012-07-05 → 2012-07-12
Assignee | ||
Updated•12 years ago
|
Target Milestone: 2012-07-12 → 2012-07-19
Assignee | ||
Comment 7•12 years ago
|
||
We have carrier stores! https://github.com/mozilla/zamboni/commit/218818f91c62f060e50f7159830fb40a1ecf508e
This approach supports carriers as subdirectories, like m.m.o/telefonica/ . Once you connect to a store, you are pinned to that store unless you manually edit the URL.
For developers, we get:
- a CARRIER variable set to None or 'telefonica' or whatever in templates.
- mkt.carriers.get_carrier() which returns the name or None
- the base template adds CARRIER to the body class
Right now only telefonica is supported but it doesn't do anything except mimic the normal site. Carrier names are editable in settings.CARRIER_URLS
Status: NEW → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Target Milestone: 2012-07-19 → 2012-08-09
You need to log in
before you can comment on or make changes to this bug.
Description
•