Closed
Bug 769514
Opened 12 years ago
Closed 12 years ago
Kill the Mac bitmap fallback code in nsSVGOuterSVGFrame
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Roc tells me that with Layers we shouldn't be drawing direct to the window, so it seems like the bitmap fallback code in nsSVGOuterSVGFrame is useless and should just be removed.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #637750 -
Flags: review?(roc)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Err, ignore the nsSVGGlyphFrame.cpp change.
|
|
Assignee | |
Comment 3•12 years ago
|
||
Just for record keeping, this was previously tried in bug 411334.
Comment on attachment 637750 [details] [diff] [review]
patch
Review of attachment 637750 [details] [diff] [review]:
-----------------------------------------------------------------
R+ with that
::: layout/svg/base/src/nsSVGOuterSVGFrame.cpp
@@ +492,5 @@
> #endif
>
> aContext->PushState();
> + frame->Paint(aBuilder, aContext, mVisibleRect, ToReferenceFrame());
> + aContext->PopState();
we shouldn't need this PushState/PopState pair. Try removing it.
Attachment #637750 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Target Milestone: --- → mozilla16
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•