Now, we're handling ISO_Level3_Shift and Mode_Switch as AltGr on GTK. ISO_Level5_Shift should also be handled as AltGr in DOM level. ISO_Level3_Shift and ISO_Level5_Shift don't share the Mod flag, of course. So, we need to store them separately. Perhaps, Mode_Switch could have an independent modifier flag, but I don't know the actual cases.

Comment on attachment 637791 [details] [diff] [review] Patch Oh, level5 keys are defined in GTK3. We should define them ourselves.

Comment on attachment 640173 [details] [diff] [review] Patch Renaming the ALTGR modifier to LEVEL3 and adding LEVEL5 looks fine (because these will correspond to different modifier bits). But I don't follow why you map them both to the same NS_VK_ALTGR and MODIFIER_ALTGRAPH because I expect the function of the level 3 and level 5 is quite different? >+// ISO level5 shift is supported on GTK3 >+#define GDK_ISO_Level5_Shift 0xFE11 >+#define GDK_ISO_Level5_Latch 0xFE12 >+#define GDK_ISO_Level5_Lock 0xFE13 Please wrap this in "#if MOZ_WIDGET_GTK == 2".

I guess you just want the DOM to know that a modifier is down, so that it doesn't treat the key in the regular way, and there is no other DOM modifier suitable?

Comment on attachment 640173 [details] [diff] [review] Patch Sounds fine if comment 4 is the motivation. > >+// ISO level5 shift is supported on GTK3 > >+#define GDK_ISO_Level5_Shift 0xFE11 > >+#define GDK_ISO_Level5_Latch 0xFE12 > >+#define GDK_ISO_Level5_Lock 0xFE13 > > Please wrap this in "#if MOZ_WIDGET_GTK == 2". Or perhaps better, "#ifndef GDK_ISO_Level5_Shift".

(In reply to Karl Tomlinson (:karlt) from comment #4) > I guess you just want the DOM to know that a modifier is down, so that it > doesn't treat the key in the regular way, and there is no other DOM modifier > suitable? Absolutely. D3E doesn't assume there is a platform which has two or more AltGr like modifier key. I guess that Web Apps developers want to know if the key press event is fired with AltGr like key.