Closed
Bug 769658
Opened 12 years ago
Closed 12 years ago
[OS.File] Split OS.Constants.Sys and OS.Constants.Path
Categories
(Core :: Networking: File, enhancement)
Core
Networking: File
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: Yoric, Assigned: Yoric)
References
Details
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
libxulpath has nothing to do in OS.Constants.Sys, and we intend to add a number of other paths, so let's split OS.Constants.Sys in two: OS.Constants.Sys (which should in time receive the contents of nsSystemInfo) and OS.Constants.Path (which should in time receive the contents of the NS_GetSpecialDirectory).
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → dteller
Attachment #637904 -
Flags: review?(khuey)
Assignee | ||
Updated•12 years ago
|
Severity: normal → enhancement
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #637905 -
Flags: review?(khuey)
Attachment #637904 -
Flags: review?(khuey) → review+
Comment on attachment 637905 [details] [diff] [review]
Companion testsuite
Review of attachment 637905 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/system/tests/worker_constants.js
@@ +38,5 @@
> function isnot(a, b, description) {
> send({kind: "isnot", a: a, b:b, description:description});
> }
>
> +// Test that OS.Consatnts.Sys.Name is defined
misspelling
Attachment #637905 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #637904 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Attachment #638642 -
Flags: review+
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #637905 -
Attachment is obsolete: true
Attachment #638643 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 6•12 years ago
|
||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/df770ecef00a
https://hg.mozilla.org/mozilla-central/rev/a198f8d63027
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•