Closed
Bug 76970
Opened 24 years ago
Closed 23 years ago
[MLK] Leaking UNICODE string in nsNSSComponent::GetPIPNSSBundleString
Categories
(Core Graveyard :: Security: UI, defect)
Tracking
(Not tracked)
psm2.0
People
(Reporter: beard, Assigned: javi)
References
()
Details
(Keywords: memory-leak)
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Leaking UNICODE strings. The call to mPIPNSSBundle->GetStringFromName(name, &
ptrv) returns a newly allocated UNICODE string, which you assign to outString on
the next line. But this assignment makes another copy, and you return immediately
without freeing ptrv. Trivial leak.
|
Reporter | |
Comment 1•24 years ago
|
||
Reassigning to apparent author of code.
Assignee: ddrinan → javi
Keywords: mlk
|
|
Reporter | |
Comment 2•24 years ago
|
||
Oops, wrong component, changing component to NSS.
Component: Client Library → Libraries
Product: PSM → NSS
Version: 2.0 → 3.0
|
|
Reporter | |
Updated•24 years ago
|
Summary: [MLK] → [MLK] Leaking UNICODE string in nsNSSComponent::GetPIPNSSBundleString
|
Assignee | |
Updated•23 years ago
|
Component: Libraries → Client Library
Product: NSS → PSM
Target Milestone: --- → 2.0
Version: 3.0 → 2.0
|
|
Assignee | |
Comment 3•23 years ago
|
||
A fix for this is included in the patch for Bug 78012 and will go in whenever
that lands.
Depends on: 78012
|
|
Assignee | |
Comment 4•23 years ago
|
||
patch for bug 78012 has landed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 6•23 years ago
|
||
Sorry, this isn't fixed as of version 1.42 of the file. I can see the leak still
by inspection. Updating the URL field of the bug to the latest location of the
offending line of code.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
|
|
Reporter | |
Comment 7•23 years ago
|
||
To verify these bug fixes, one really needs to use a memory leak tool, such as
purify, or the Boehm GC leak detector.
|
|
Reporter | |
Comment 8•23 years ago
|
||
|
||
Comment 9•23 years ago
|
||
dup
*** This bug has been marked as a duplicate of 82359 ***
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → DUPLICATE
|
|
Reporter | |
Comment 10•23 years ago
|
||
You marked this as a duplicate of a NEWER bug because resolving that bug will fix
this one? I perused 82359 but didn't see any obvious connection.
|
|
Reporter | |
Comment 11•23 years ago
|
||
Having read the bug more closely, I see the connection. Fine, keep my bug closed.
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•