Closed
Bug 77039
Opened 24 years ago
Closed 23 years ago
[FIX]Setting selectedIndex on SELECT MULTIPLE does not clear existing selections
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla0.9.2
People
(Reporter: otto, Assigned: john)
References
Details
(Whiteboard: [FIX])
Attachments
(2 files)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
rods
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
According to the Netscape 4 docs, "Setting
selectedIndex clears any other options that are selected in the Select object."
Mozilla 0.8.1 (Win32) does not exhibit this behavior -- existing selections
remain after selectedIndex is set.
|
||
Comment 3•24 years ago
|
||
seeing this on linux build 2001-04-22-21 as well.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: correctness,
mozilla1.0
OS: Windows 2000 → All
|
||
Updated•24 years ago
|
Target Milestone: --- → mozilla1.0
|
||
Comment 4•24 years ago
|
||
Patch:
Index: nsListControlFrame.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/forms/src/nsListControlFrame.cpp,v
retrieving revision 1.194
diff -u -r1.194 nsListControlFrame.cpp
--- nsListControlFrame.cpp 2001/05/30 11:26:18 1.194
+++ nsListControlFrame.cpp 2001/05/30 14:43:55
@@ -2745,7 +2745,9 @@
}
// if it is a multiple, select the new item
if (multiple) {
+ Deselect();
SetOptionSelected(selectedIndex, PR_TRUE);
+ mSelectedIndex = selectedIndex;
} else {
// if it is a single select,
// check to see if it is the currect selection
Status: NEW → ASSIGNED
Summary: Setting selectedIndex on SELECT MULTIPLE does not clear existing selections → [FIX]Setting selectedIndex on SELECT MULTIPLE does not clear existing selections
Whiteboard: Fix in Hand
Target Milestone: mozilla1.0 → mozilla0.9.2
|
|
||
Comment 5•24 years ago
|
||
|
||
Comment 6•24 years ago
|
||
sr=attinasi
|
||
Comment 7•24 years ago
|
||
a=dbaron for trunk checkin (on behalf of drivers)
|
|
||
Comment 8•24 years ago
|
||
fixed
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
||
Comment 9•23 years ago
|
||
bug 148645 may cause a reopen.
|
|
||
Comment 10•23 years ago
|
||
*** Bug 148645 has been marked as a duplicate of this bug. ***
|
Reporter | |
Comment 11•23 years ago
|
||
This seems to have regressed -- On RC3, setting selectedIndex on a SELECT
MULTIPLE no longer clears the existing selection (as with Netscape 4 and IE).
See testcase attachment.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Comment 12•23 years ago
|
||
John, got any ideas on this bug?
|
Assignee | |
Comment 13•23 years ago
|
||
I have a fix, reassigning so that I will find this bug again.
Assignee: rods → jkeiser
Status: REOPENED → NEW
|
|
Assignee | |
Updated•23 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 14•23 years ago
|
||
I guess I missed that when I redid select last year. Here ya go.
|
|
Assignee | |
Comment 15•23 years ago
|
||
IE6 works this way too, and it seems like reasonable behavior to me.
Whiteboard: Fix in Hand → [FIX]
|
|
||
Comment 16•23 years ago
|
||
Comment on attachment 86342 [details] [diff] [review]
Patch
r=rods
Attachment #86342 -
Flags: review+
|
|
||
Comment 17•23 years ago
|
||
Comment on attachment 86342 [details] [diff] [review]
Patch
sr=jst
Attachment #86342 -
Flags: superreview+
|
|
Assignee | |
Comment 18•23 years ago
|
||
Fix checked in to trunk.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•