Closed
Bug 77104
Opened 24 years ago
Closed 22 years ago
Remove Account prompt should say which account
Categories
(SeaMonkey :: MailNews: Account Configuration, defect, P2)
SeaMonkey
MailNews: Account Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.2alpha
People
(Reporter: jruderman, Assigned: caillon)
References
Details
(Keywords: polish)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
sspitzer
:
review+
sspitzer
:
superreview+
sspitzer
:
approval1.4b+
|
Details | Diff | Splinter Review |
mail, edit->account settings, remove account
'Are you sure you want to remove this account?'
should be
'Are you sure you want to remove the account "davidr8@home.com"?'
|
||
Comment 1•23 years ago
|
||
Taking.
Assignee: racham → jg
OS: Windows 98 → All
Hardware: PC → All
Target Milestone: --- → mozilla0.9.8
|
|
||
Updated•23 years ago
|
|
|
||
Comment 2•23 years ago
|
||
Bouncing out, hope someone with more time than I catches.
Assignee: jg → racham
Status: ASSIGNED → NEW
|
||
Updated•22 years ago
|
Keywords: mozilla1.0.1,
nsbeta1
|
||
Comment 3•22 years ago
|
||
Discussed in mail news bug meeting. Decided to minus this bug.
|
|
||
Updated•22 years ago
|
Keywords: mozilla1.1
|
||
Comment 4•22 years ago
|
||
*** Bug 137497 has been marked as a duplicate of this bug. ***
|
|
||
Updated•22 years ago
|
Flags: blocking1.4b?
|
||
Updated•22 years ago
|
Flags: blocking1.4b? → blocking1.4b-
|
Assignee | |
Comment 5•22 years ago
|
||
|
|
Assignee | |
Comment 7•22 years ago
|
||
Er, use the right address this time. ;-)
Assignee: evang-obsolete → caillon
|
||
Comment 8•22 years ago
|
||
Comment on attachment 122432 [details] [diff] [review]
Patch
r=me if you get sr=sspitzer
Attachment #122432 -
Flags: review+
|
||
Comment 9•22 years ago
|
||
Comment on attachment 122432 [details] [diff] [review]
Patch
don't go right through prefs.
do account.server.prettyName
see nsMsgFolderDataSource::createFolderNameNode()
and
nsMsgFolder::GetName()
for why I think that's right.
for bonus points, rewrite to remove window.confirm.
you should be getting an assert about not using window.confirm from chrome.
Attachment #122432 -
Flags: superreview-
|
|
||
Comment 10•22 years ago
|
||
var promptService =
Components.classes["@mozilla.org/embedcomp/prompt-service;1"].getService(Components.interfaces.nsIPromptService);
if (!promptService.confirm(window, title, message))
...
|
|
Assignee | |
Comment 11•22 years ago
|
||
Addresses seth's comments. I can't believe I missed the prettyName on
nsIMsgIcomingServer since I found key which is right above that. Weird...
Attachment #122432 -
Attachment is obsolete: true
|
|
||
Comment 12•22 years ago
|
||
Comment on attachment 122516 [details] [diff] [review]
Patch v2
r/sr/a=sspitzer
thanks chris!
Attachment #122516 -
Flags: superreview+
Attachment #122516 -
Flags: review+
Attachment #122516 -
Flags: approval1.4b+
|
|
Assignee | |
Comment 13•22 years ago
|
||
Checking in mailnews/base/prefs/resources/content/AccountManager.js;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/AccountManager.js,v <--
AccountManager.js
new revision: 1.96; previous revision: 1.95
done
Checking in mailnews/base/prefs/resources/locale/en-US/prefs.properties;
/cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/prefs.properties,v
<-- prefs.properties
new revision: 1.27; previous revision: 1.26
done
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•