Closed
Bug 771159
Opened 12 years ago
Closed 12 years ago
Reader Mode: Texture used on toolbar background is too pixilated
Categories
(Firefox for Android Graveyard :: Reader View, defect)
Tracking
(firefox16 verified, fennec16+)
VERIFIED
FIXED
Firefox 17
People
(Reporter: pretzer, Unassigned)
References
Details
Attachments
(3 files)
(deleted),
image/png
|
Details | |
(deleted),
application/x-zip-compressed
|
Details | |
(deleted),
patch
|
mfinkle
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The texture that is used on the background of the reader mode toolbar is much more pixilated than the one used on the area around the URL field at the top. This looks odd and they should use the same texture, in my opinion.
See also bug 758804, which changed the texture of the upper toolbar to a more subtle version in the past.
Updated•12 years ago
|
Component: Evangelism → General
Comment 1•12 years ago
|
||
I think Mark referenced this in channel, but I'm not sure if it was the bar or something else. I don't see it that much on my Galaxy Nexus.
Component: General → Reader Mode
Reporter | ||
Comment 2•12 years ago
|
||
Actually it look worse in reality than on the screenshot for me. I'm running a Galaxy S2 with Android 4.0.3 if that helps.
Comment 3•12 years ago
|
||
Might be because we don't provider toolbar background per screen density. Image is probably being scaled up. Ian, could please you provide the assets?
Comment 4•12 years ago
|
||
Yep, here you go Lucas.
Reporter | ||
Updated•12 years ago
|
tracking-fennec: --- → ?
status-firefox16:
--- → affected
Comment 5•12 years ago
|
||
Attachment #644229 -
Flags: review?(mark.finkle)
Comment 6•12 years ago
|
||
Comment on attachment 644229 [details] [diff] [review]
Properly set toolbar's background size to handle different densities
I'm a little sad that we need different backgrounds for portrait and landscape, in addition to density. This makes me not want to use nosiy backgrounds. Too much waste.
Attachment #644229 -
Flags: review?(mark.finkle) → review+
Comment 7•12 years ago
|
||
I wonder if changing the way we apply the noise might help? Like just have one "noise" image that is a transparent overlay everywhere?
Comment 8•12 years ago
|
||
(In reply to Ian Barlow (:ibarlow) from comment #7)
> I wonder if changing the way we apply the noise might help? Like just have
> one "noise" image that is a transparent overlay everywhere?
That could work. We'd still need one image per screen density though. But it's better than having 9 images.
Comment 9•12 years ago
|
||
Yeah. I think I'm going to open a separate bug about this, seems like a pretty worthwhile discussion to have, and not just within the scope of reader mode. :)
Updated•12 years ago
|
tracking-fennec: ? → 16+
Comment 10•12 years ago
|
||
Pushed as we now have a follow up bug to work on optimizing out assets.
http://hg.mozilla.org/integration/mozilla-inbound/rev/d9c31ba74029
Comment 11•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Comment 12•12 years ago
|
||
Comment on attachment 644229 [details] [diff] [review]
Properly set toolbar's background size to handle different densities
[Approval Request Comment]
Fix on reader mode which is planned for F16.
Attachment #644229 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
Attachment #644229 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 13•12 years ago
|
||
Pushed to Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/3c61eb8b9a04
Updated•12 years ago
|
Updated•12 years ago
|
Status: RESOLVED → VERIFIED
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•