Closed Bug 77122 Opened 24 years ago Closed 22 years ago

context menu for <input type=image> has frame options, lacks image and form-submit options

Categories

(SeaMonkey :: UI Design, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED WORKSFORME
mozilla1.1alpha

People

(Reporter: jruderman, Assigned: morse)

References

()

Details

(Whiteboard: se-radar)

Attachments

(1 file, 1 obsolete file)

Noticed while looking at bug 69882: The context menu for an image submit button looks like the context menu for a blank part of a frame (even on a non-framed page). It should have image- and page-related items that would be shown for an image link, and form-related items that would be shown on a normal form-submit button. I'm not getting any javascript errors.
Target Milestone: --- → Future
Depends on: 83883
reassigning
Assignee: rods → pollmann
Hmm I cant even put out an IMAGE submenu on windows 98 build 2001-06-04-09-0.9.1
--> Context Menu Guru
Assignee: pollmann → law
Component: Form Submission → XP Apps
OS: Windows 98 → All
Hardware: PC → All
Target Milestone: Future → ---
*** Bug 97476 has been marked as a duplicate of this bug. ***
nominating for 0.9.5... from bug 97476: image options missing in context menu for INPUT TYPE=IMAGE, including View Image, Save Image and Copy Image Location. however, in bug 97476, this appears to be a problem on win32 [eg, winNT and win2k], but not on linux or mac os x. sample test sites [bring up the context menu on the button images]: http://www.centrum.cz/ http://www.mesec.cz/ http://hotbot.lycos.com/
Keywords: mozilla0.9.5
Summary: context menu for <input type=image> has frame options; should have image and form-submit options → context menu for <input type=image> has frame options or missing image options; should have image and form-submit options
Whiteboard: se-radar
Summary: context menu for <input type=image> has frame options or missing image options; should have image and form-submit options → context menu for <input type=image> has frame options, lacks image and form-submit options
Is bug 101550 related to or a dupe of this bug?
No, bug 101550 concerns missing support for context menus for client-side image maps. This is not that.
Target Milestone: --- → mozilla1.0
*** Bug 78558 has been marked as a duplicate of this bug. ***
->context menu owner Steve, here's another one. I haven't looked at this in a while so I don't know what state this is in. Thanks.
Assignee: law → morse
*** Bug 83883 has been marked as a duplicate of this bug. ***
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 (you can query for this string to delete spam or retrieve the list of bugs I've moved)
Target Milestone: mozilla1.0 → mozilla1.0.1
This is now a WFM with Build ID 2002022103, Win 98.
*** Bug 127230 has been marked as a duplicate of this bug. ***
Still seeing this with 2002022103 on Win2k. Sebastian: You tried right clicking on one of the "More" images at the URL above? I see now "View Image" in the context menu for those :-/.
This bug is about wrong context menu for <input type=image> images (frame context menu instead of image context menu). When I click on the "more" image I get the correct image context menu (Block images from server, Save image, Copy image location etc., no frame options). Also tested with some dups. So this is definitly a WFM for me. (See also bug 127230 comment #3) (@abischøff >>I see now "View Image" in the context menu for those<<, you meant "I see no ...", did you?)
Sebastian: Keyword "pp"? Perhaps there's something divergent between Win98 (your OS) and Win2k (mine) ? Removing "mozilla0.9.5" keyword (that's long gone).
Keywords: mozilla0.9.5
*** Bug 122708 has been marked as a duplicate of this bug. ***
*** Bug 129747 has been marked as a duplicate of this bug. ***
Attached patch proposed patch (obsolete) (deleted) — Splinter Review
(first patch, maybe complete crap) I tried to find the reason for this bug and noticed that onpopupshowing of the contextmenu is called 3 times on a <input type=image> element, but wasnt able to figure out the reason for this. When its called the first time the context menu was ok, so I added a wrapper which takes the first constructed context menu. Please note that this is a workaround (although it works perfect); a real patch would have changed onpopupshowing calling behaviour. I tested this only on win98 and hope that it will work on other platforms too.
Attached patch yet better patch (deleted) — Splinter Review
Attachment #77431 - Attachment is obsolete: true
*** Bug 137385 has been marked as a duplicate of this bug. ***
blake, any idea what's up here?
Reading today's checkin log, I see the following comment (revision 3.79 of layout/html/forms/src/nsImageControlFrame.cpp): "Stop image control frame stomping on the event status. This stops context menu events being propogated to their parents and sent twice for input elements with images. bugscape=14131 r=saari@netscape.com sr=jst@netscape.com" I suspect that this checkin will fix this bug... but since I cannot reproduce the bug to start with I can't really test that. So if someone who's seeing this could please try tomorrow's build, that would be great.
This is fixed on the 2002050204 trunk build.
Depends on: 143033
Here's another bug. Can't "Copy Image Location" via the context menu from <input type=image ...>, clipboard remains unaltered.
Closing out as fixed per comments 23 and 24. If I'm wrong and it's still a problem, then reopen.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Reopening. Context menu may have options, but they really should work be functional. Last revisited w/ 2002 0511 08.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
That is, reopening due to comment #25
Target Milestone: mozilla1.0.1 → mozilla1.1alpha
reassigned to component owner
Assignee: morse → sgehani
Status: REOPENED → NEW
QA Contact: vladimire → paw
Steve, this covers more of your domain: context menus, images, and forms. What component should it be assigned to? I'll let you decide.
Assignee: sgehani → morse
It looks like this bug is morphing. The bug is about the image items not appearing in the context menu. And that has since been fixed according to the many WFMs found in this report. It also works for me as I just tried it. So it was closed out as WFM and then in comment 28 Blu3 said "reopening per comment 25. But you can't do that -- comment 25 is an entirely different bug. If you want to persue that, then open a new report on it. But the symptoms described in this but are no longer present. So closing out once again as WFM.
Status: NEW → RESOLVED
Closed: 23 years ago22 years ago
Resolution: --- → WORKSFORME
v
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: