Closed
Bug 771588
Opened 12 years ago
Closed 12 years ago
libvpx encoder fails to build with "Too many sections"
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: jesup, Assigned: jesup)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
May be related to the update of MSVC to 10 on the builders.
Fails in host_obj_int_extract.exe
When this failed in the "eliminate gkmedia tests" (bug 768325), turning off PGO solved it. The offset extractor fails with "Too Many Sections", it fails to parse something correctly and goes off in the weeds. Derf has the output of a local build showing the problem (with full PGO). This may happen due to a related opt which may be disabled if we explicitly disable PGO - I'll try that.
This blocks turning on webrtc in m-c
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Comment 2•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #639905 -
Attachment is obsolete: true
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 639909 [details] [diff] [review]
don't PGO asm_enc_offsets.c in libvpx - fix for MSVC2010
per https://tbpl.mozilla.org/php/getParsedLog.php?id=13301040&tree=Try&full=1 this appears to work (PGO is forced in that try push). Added the WINNT tests after that try.
Changed both asm_com_offsets and asm_enc_offsets, since PGO has no purpose here and it's playing with fire to leave it on for asm_com_offsets. Note I used .obj directly since I couldn't use $(OBJ_SUFFIX) (it bitched at me for trying).
Probably need r+ from a build peer; or build peer plus Tim
Attachment #639909 -
Flags: review?(tterribe)
Attachment #639909 -
Flags: review?(ted.mielczarek)
Attachment #639909 -
Flags: review?(mh+mozilla)
Attachment #639909 -
Flags: review?(khuey)
Comment 4•12 years ago
|
||
Comment on attachment 639909 [details] [diff] [review]
don't PGO asm_enc_offsets.c in libvpx - fix for MSVC2010
Review of attachment 639909 [details] [diff] [review]:
-----------------------------------------------------------------
Fix at least the first issue, and we should be good.
::: media/libvpx/Makefile.in
@@ +441,5 @@
> HOST_PROGRAM = host_obj_int_extract$(HOST_BIN_SUFFIX)
>
> CSRCS += asm_com_offsets.c
>
> +ifeq (WINNT,$(OS_TARGET))
I think this needs to make sure we're using MSVC, as well, since someone could be doing a mingw32 build. Cargo-culting Mozilla's top-level Makefile.in, ifeq(WINNT_,$(OS_TARGET)_$(GNU_CC)) should work, I think.
@@ +442,5 @@
>
> CSRCS += asm_com_offsets.c
>
> +ifeq (WINNT,$(OS_TARGET))
> +asm_com_offsets.obj: CFLAGS += -GL-
To use $(OBJ_SUFFIX) outside of a recursively-expanded variable, you need to add this rule after including rules.mk (see the comment on line 484).
I don't know how much this matters for MSVC builds, as I don't expect this suffix to ever change.
Attachment #639909 -
Flags: review?(tterribe) → review-
Assignee | ||
Updated•12 years ago
|
Attachment #639909 -
Flags: review?(ted.mielczarek)
Attachment #639909 -
Flags: review?(mh+mozilla)
Attachment #639909 -
Flags: review?(khuey)
Assignee | ||
Comment 5•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #639909 -
Attachment is obsolete: true
Assignee | ||
Comment 6•12 years ago
|
||
Comment on attachment 639953 [details] [diff] [review]
don't PGO asm_enc_offsets.c in libvpx - fix for MSVC2010
https://tbpl.mozilla.org/?tree=Try&rev=1654d3f416a5
(or https://tbpl.mozilla.org/?tree=Try&pusher=rjesup@wgate.com if try/tbpl is still unhappy)
That try run is with PGO for windows (with turning on webrtc by default)
Need review from 1 build peer, but didn't know who'd be available this weekend.
Attachment #639953 -
Flags: review?(ted.mielczarek)
Attachment #639953 -
Flags: review?(mh+mozilla)
Attachment #639953 -
Flags: review?(khuey)
Comment 7•12 years ago
|
||
Comment on attachment 639953 [details] [diff] [review]
don't PGO asm_enc_offsets.c in libvpx - fix for MSVC2010
The better way to write this is "ifdef _MSC_VER". r=me with that
Attachment #639953 -
Flags: review?(ted.mielczarek)
Attachment #639953 -
Flags: review?(mh+mozilla)
Attachment #639953 -
Flags: review?(khuey)
Attachment #639953 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Assignee: tterribe → rjesup
Assignee | ||
Comment 8•12 years ago
|
||
Comment 9•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in
before you can comment on or make changes to this bug.
Description
•