Closed
Bug 772233
Opened 12 years ago
Closed 11 years ago
Way to test options passed to main
Categories
(Add-on SDK Graveyard :: General, defect, P2)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: irakli, Assigned: evold)
References
Details
Attachments
(1 file)
We had a regression recently in one of the options passed to main function (see Bug 771825). Unfortunately we don't have infrastructure to have tests for that. We need to build one.
Priority: -- → P2
|
Assignee | |
Comment 1•12 years ago
|
||
bug 745877 would handle this use case
|
|
Assignee | |
Comment 2•12 years ago
|
||
So we have the test infrastructure for this now, but do we still support the main function?
Flags: needinfo?(rFobic)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → evold
OS: Mac OS X → All
Hardware: x86 → All
|
|
Assignee | |
Comment 4•12 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Updated•12 years ago
|
Attachment #740646 -
Flags: review?(zer0)
|
|
Assignee | |
Comment 5•12 years ago
|
||
|
|
Assignee | |
Comment 6•11 years ago
|
||
Comment on attachment 740646 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/960
This pull request is now 3 months old, I'm giving it to someone else.
Attachment #740646 -
Flags: review?(zer0) → review?(jsantell)
|
||
Comment 7•11 years ago
|
||
Comment on attachment 740646 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/960
Some nits in the PR, but tests look good
Attachment #740646 -
Flags: review?(jsantell) → review+
|
||
Comment 8•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/b909978ac8fc8ff30f202768f5c043cd874ae4b7
Bug 772233: basic tests for exports.main in main.js
https://github.com/mozilla/addon-sdk/commit/6fc0a7e6c3ae96ad9cba6a82dce356cc09c31767
Merge pull request #960 from erikvold/772233
Bug 772233: basic tests for exports.main in main.js r=@jsantell
Depends on: 897683
I'm going through the list of open bugs that github robot has commented in. Is this bug fixed, Erik?
Flags: needinfo?(evold)
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(evold)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•