Closed
Bug 772261
Opened 12 years ago
Closed 11 years ago
Add duration to token server and client
Categories
(Cloud Services :: Firefox: Common, defect)
Cloud Services
Firefox: Common
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla29
People
(Reporter: gps, Assigned: ckarlof)
References
Details
(Whiteboard: [qa?])
Attachments
(1 file)
(deleted),
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
Apparently "duration" was added to the token server API. We need to reflect this change in the JS client and test code.
Comment 1•12 years ago
|
||
My latest patch touches up a couple of these references, but isn't very thorough as far as changes all destructing assignments of tokens, for example.
Comment 2•12 years ago
|
||
I think we need a meta bug for desktop protocol 2.0 implementation. Blocking the ZOMG bug for now.
Reporter | ||
Updated•11 years ago
|
Assignee: gps → nobody
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → ckarlof
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #8346812 -
Flags: review?(rnewman)
Comment 5•11 years ago
|
||
Comment on attachment 8346812 [details] [diff] [review]
Added "duration" to TokenServer Client
Review of attachment 8346812 [details] [diff] [review]:
-----------------------------------------------------------------
Looks trivial to me.
Attachment #8346812 -
Flags: review?(rnewman) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d81d2e84b076
Chris, for future patches, please make sure the necessary commit information is included. Makes life much easier for those checking in on your behalf. Thanks! :)
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla29
Updated•11 years ago
|
Whiteboard: [qa?]
Comment 8•11 years ago
|
||
Cleaning up Resolved/Fixed bugs from December's first release.
Verified that we now have a working first-release of FxA to Desktop/Android Nightly.
Re-open as needed.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•