Closed Bug 772538 Opened 12 years ago Closed 4 years ago

[OS.File] Implement recursive directory traversal

Categories

(Toolkit Graveyard :: OS.File, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: Yoric, Unassigned, Mentored)

References

Details

(Keywords: dev-doc-needed, Whiteboard: [Async:ready][lang=js])

Attachments

(4 files, 1 obsolete file)

This will considerably simplify implementations of removing directories, moving/copying directories across drives, etc.
Attached patch Companion testsuite (deleted) — Splinter Review
Attachment #640661 - Flags: review?(taras.mozilla)
Attached patch Unix front-end (obsolete) (deleted) — Splinter Review
Attachment #640663 - Flags: review?(taras.mozilla)
Attached patch Unix front-end (deleted) — Splinter Review
Attachment #640663 - Attachment is obsolete: true
Attachment #640663 - Flags: review?(taras.mozilla)
Attachment #640665 - Flags: review?(taras.mozilla)
Attached patch Shared code (deleted) — Splinter Review
Attachment #640667 - Flags: review?(taras.mozilla)
Attached patch Windows front-end (deleted) — Splinter Review
Attachment #640668 - Flags: review?(taras.mozilla)
Comment on attachment 640665 [details] [diff] [review]
Unix front-end

i'm confused, why are we jumping into recursive directory iteration first?
Attachment #640665 - Flags: review?(taras.mozilla)
Please un r? me here. I do not believe moving/copying directories across drives is any sort of priority for us.
Attachment #640661 - Flags: review?(taras.mozilla)
Attachment #640667 - Flags: review?(taras.mozilla)
Attachment #640668 - Flags: review?(taras.mozilla)
(In reply to Taras Glek (:taras) from comment #6)
> Comment on attachment 640665 [details] [diff] [review]
> Unix front-end
> 
> i'm confused, why are we jumping into recursive directory iteration first?

It's not a matter of "first", it's a matter of everything else in my todo list waiting for reviews :)

Plus, the work on thumbnail storage by ttaubert and/or myself requires removing directory structures. Which in turns requires being able to walk them.
I'm skeptical of the need for this. If you are stuck on reviews, snappy bugs are a better priority than stacking on top of unreviewed work.
Well, if you look at thumbmail storage, there is a method |wipe: function Storage_wipe| that removes a directory hierarchy, completely on main thread.

Btw, this bug is not based on unreviewed work. It is based on landed work (bug 764436).
No longer blocks: 761138
No longer blocks: 753768
I don't have time to work on this at the moment.
Assignee: dteller → nobody
Whiteboard: [Async]
Component: Networking: File → OS.File
Product: Core → Toolkit
Severity: normal → minor
Whiteboard: [Async] → [Async:ready][mentor=Yoric][lang=js]
No longer blocks: 756315
Mentor: dteller
Whiteboard: [Async:ready][mentor=Yoric][lang=js] → [Async:ready][lang=js]
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: