We don't encode the query for about:reader URIs. This can cause the reader mode to parse the wrong page page, causing a number of sites - like bugzilla.mozilla.org - to fail. It might be cleaner to factor this out into a method somewhere, but I'm not sure what a good place would be (StringUtils?).

Comment on attachment 641761 [details] [diff] [review] encode queries >diff --git a/mobile/android/base/AwesomeBarTabs.java b/mobile/android/base/AwesomeBarTabs.java > private String getReaderForUrl(String url) { > // FIXME: still need to define the final way to open items from > // reading list. For now, we're using an about:reader page. >- return "about:reader?url=" + url; >+ return "about:reader?url=" + Uri.encode(url); > } >diff --git a/mobile/android/base/awesomebar/AwesomeBarTab.java b/mobile/android/base/awesomebar/AwesomeBarTab.java > protected String getReaderForUrl(String url) { > // FIXME: still need to define the final way to open items from > // reading list. For now, we're using an about:reader page. >- return "about:reader?url=" + url; >+ return "about:reader?url=" + Uri.encode(url); > } Maybe there is a way to share this impl for AwesomeBarTab

(In reply to Mark Finkle (:mfinkle) from comment #1) > Comment on attachment 641761 [details] [diff] [review] > encode queries > Maybe there is a way to share this impl for AwesomeBarTab I couldn't figure out a good way to do this, so I kept the patch as posted. http://hg.mozilla.org/integration/mozilla-inbound/rev/eab366e56bf1