Closed Bug 77388 Opened 24 years ago Closed 24 years ago

handle maxHits param to nsLDAPAutoCompleteSession

Categories

(MailNews Core :: LDAP Integration, defect, P3)

Product:
MailNews Core
Component:
LDAP Integration
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.2

People

(Reporter: dmosedale, Assigned: dmosedale)

References

Details

(Keywords: perf)

Attachments

(2 files)

patch v1
(deleted), patch
Details | Diff | Splinter Review
patch, v2
(deleted), patch
Details | Diff | Splinter Review
Specifically, if we hit the sizelimit, we should just return nsIAutoCompleteStatus::ignored and not autocomplete from LDAP at all. The end-user behavior would then see autocomplete entries from the addressbook but none from LDAP. This seems non-optimal, but perhaps better UI than having entries from the addressbook and some but not all entries from LDAP.
Blocks: 70933
Status: NEW → ASSIGNED
No longer blocks: 70933
Blocks: 17880
Keywords: perf
Priority: -- → P3
Target Milestone: --- → mozilla0.9.2
reassign to Olga as QA contact
QA Contact: yulian → olgac
Blocks: 79930
*** Bug 79930 has been marked as a duplicate of this bug. ***
OK, here's a patch which fixes this. Random comments: * changed the param name to be maxHits so that it matches the prefs and UI more closely * after talking to Leif and Srilatha, changed the semantics such that if the limit is hit, the maximum number of hits is returned rather than returning nothing.
Summary: handle sizeLimit param to nsLDAPAutoCompleteSession → handle maxHits param to nsLDAPAutoCompleteSession
Attached patch patch v1 (deleted) — — Splinter Review
Keywords: patch, review
Whiteboard: have patch; need review
Attached patch patch, v2 (deleted) — — Splinter Review
After some discussion with Leif, here is a patch with better error-checking and documentation for the semantics of maxHits.
Looks good, r=leif.
sr=mscott
Component: LDAP XPCOM SDK → LDAP Mail/News Integration
Keywords: review
Product: Directory → MailNews
Whiteboard: have patch; need review → have patch, r=, sr=; need a=
Blocks: 83989
a=blizzard on behalf of drivers for the trunk
No longer blocks: 83989
Whiteboard: have patch, r=, sr=; need a= → have patch, r=, sr=, a=; waiting on tree blockers
Blocks: 83989
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Whiteboard: have patch, r=, sr=, a=; waiting on tree blockers
maxHits works, pref works Verified on WinNT 4.0 , MacOS 9.1, Linux RH7.1 with 2001061204,2001061208, 2001061414 builds.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: