Closed
Bug 77388
Opened 24 years ago
Closed 23 years ago
handle maxHits param to nsLDAPAutoCompleteSession
Categories
(MailNews Core :: LDAP Integration, defect, P3)
MailNews Core
LDAP Integration
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.2
People
(Reporter: dmosedale, Assigned: dmosedale)
References
Details
(Keywords: perf)
Attachments
(2 files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Specifically, if we hit the sizelimit, we should just return
nsIAutoCompleteStatus::ignored and not autocomplete from LDAP at all. The
end-user behavior would then see autocomplete entries from the addressbook but
none from LDAP. This seems non-optimal, but perhaps better UI than having
entries from the addressbook and some but not all entries from LDAP.
|
||
Updated•24 years ago
|
|
Assignee | |
Comment 3•23 years ago
|
||
OK, here's a patch which fixes this. Random comments:
* changed the param name to be maxHits so that it matches the prefs and UI more
closely
* after talking to Leif and Srilatha, changed the semantics such that if the
limit is hit, the maximum number of hits is returned rather than returning nothing.
Summary: handle sizeLimit param to nsLDAPAutoCompleteSession → handle maxHits param to nsLDAPAutoCompleteSession
|
|
Assignee | |
Comment 4•23 years ago
|
||
|
|
Assignee | |
Updated•23 years ago
|
|
|
Assignee | |
Comment 5•23 years ago
|
||
|
|
Assignee | |
Comment 6•23 years ago
|
||
After some discussion with Leif, here is a patch with better error-checking and
documentation for the semantics of maxHits.
|
||
Comment 7•23 years ago
|
||
Looks good, r=leif.
|
||
Comment 8•23 years ago
|
||
sr=mscott
|
|
Assignee | |
Updated•23 years ago
|
Component: LDAP XPCOM SDK → LDAP Mail/News Integration
Keywords: review
Product: Directory → MailNews
Whiteboard: have patch; need review → have patch, r=, sr=; need a=
|
|
Assignee | |
Updated•23 years ago
|
Whiteboard: have patch, r=, sr=; need a= → have patch, r=, sr=, a=; waiting on tree blockers
|
|
Assignee | |
Comment 10•23 years ago
|
||
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: have patch, r=, sr=, a=; waiting on tree blockers
|
||
Comment 11•23 years ago
|
||
maxHits works, pref works
Verified on WinNT 4.0 , MacOS 9.1, Linux RH7.1 with 2001061204,2001061208,
2001061414 builds.
Status: RESOLVED → VERIFIED
|
||
Updated•20 years ago
|
Product: MailNews → Core
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•