Closed Bug 77394 Opened 24 years ago Closed 24 years ago

incorrect handling of empty text nodes (like word break)

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla0.9.3

People

(Reporter: Brade, Assigned: shanjian)

Details

(Whiteboard: patch available, need sr/a)

Attachments

(2 files)

I will attach a testcase which I developed after finding a bug when editing plain text. This testcase shows that the bug isn't in the editor but rather in the wordbreak or linebreak code when encountering empty text nodes. To reproduce: load the attachment/test case enter some text with no spaces in the 3rd editfield (such as "1234567890") press add a few times remove the text in the 3rd editfield press add a few more times (insertion of empty text nodes) enter some text with no spaces in the 3rd editfield (such as "abcdefghijkl") press add a few times until you see a line break between the first set of text and the second set of text expectation: an empty text node should not cause the line to break
erik resign. reassign all his bug to ftang for now.
Assignee: erik → ftang
shanjian- line break issue. Please help to take care
Assignee: ftang → shanjian
I do not see any problem here. In your reproduce step, you input "123456789" in 3rd edit field, and then add empty text node, and then "abcdefg". Because "123456789" and "abcdefg" are of different category, line/word break might happen. If you just use "aaaa" and "bbbb" and such, you will see that it works fine. Reopen if my understanding is incorrect.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → WORKSFORME
reopen bug until we've clarified... Shanjian--can you explain what you mean by "are of different category"? This can be reproduced by using the same string ("abcdefghijklmnopqrst") with empty text nodes. The text added doesn't really matter, the problem seems to be with the empty text nodes.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
brade- how important is this one? is it moz0.9.2 or future?
Without a fix, people might see wierd wrapping while deleting lines in textareas. Several people have already reported this problem. This bug was filed just to prove that the problem exists outside of the editor context. Wrapping content that contained empty text nodes used to work, so something regressed it.
Ok, I reproduced the problem and found out that this is a layout issue. patch will follow soon.
Status: REOPENED → ASSIGNED
set milstone to 0.9.3. We might want to change it to 0.9.2.
Whiteboard: patch available, need r/sr/a
Target Milestone: --- → mozilla0.9.3
Nice! r=waterson
chris, since you are a super-reviewer, can you give sr as well?
Whiteboard: patch available, need r/sr/a → patch available, need sr/a
add attinasi@netscape.com to cc list Marc, can you sr this one?
sr=attinasi
fix checked in to trunk.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
Marking verified fixed in the Sept 5th build (2001-09-05-05)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: