I was browsing and I noticed that websites that I've been on a long time ago and deleted from my history were showing up as suggestions when I was typing in my history. Some of the websites were from a few months before I updated firefox. Reproducible: Always. Steps to reproduce: 1. Type in a website into the location bar, for example www.greyhound.com, and hit Enter to go to the website. 2. Go to the "Show All History" window and delete the website you typed in. 2.5. OPTIONAL: Restart firefox. 3. Begin typing url of the website into the location bar. Expected results: The website that was deleted will not show up in the location bar suggestions. Actual results: The deleted website shows up in the location bar suggestions. This happens regardless of whether or not firefox was restarted. This will even happen with websites that were deleted before firefox was updated.

I can not reproduce the issue with Firefox 13.0.1 1) entered www.greyhound.com 2) opened the history window, searched the entry and selected "Forget about this site" from the context menu 3) the entry doesn't appear any longer in the URL bar.

Be sure these entries are not a part of your bookmarks (with the yellow stars on their right).

@Loic None of the entries were part of my bookmarks.

how has this been confirmed if comment 1 can't reproduce? Btw, removals in some cases may be asynchronous, that means it may take some minutes before entries are completely removed. Deleting pages from the Library may act differently than Forget about this site. So how exactly did you delete pages in point 2, just select and del?

I'd like to confirm this issue. What I've done: deleted my recent history (all / complete), deleted all bookmarks FF still suggests pages I've visited long ago in the location bar. Changed Address-Bar Suggestion-Mode (Privacy / LocationBar) to: - Suggest from History only -> Result: Link is suggested - Suggest from Bookmarks only -> Result: Link is suggested - Suggest from B & H -> Result: Link is suggested - Deactivate / nothing -> Result: Nothing is suggested. Version: Recent 16.0 Beta OS: Win7x64 Behaviour also shows with deactivated plugins (safe mode) and in private mode

How did you remove history? Did you select Everything and Browsing and Download history from Clear Recent History? How did you remove bookmarks? How much time did you wait after clearing history before checking the suggestions?

(In reply to Marco Bonardo [:mak] from comment #6) > How did you remove history? Did you select Everything and Browsing and > Download history from Clear Recent History? CTRL + SHIFT + DEL -> Dropdown: All/Complete -> Checkboxes: Everything whats possible. > How did you remove bookmarks? CTRL + SHIFT + B -> Select All, DEL > How much time did you wait after clearing history before checking the > suggestions? Differnt. Could Also reproduce this after a Browser restart. In which file are those suggestions / from which file are they produced? I could not reproduce the faulty behaviour with a new Browser-Profile.

(In reply to mozilla from comment #7) > > How did you remove history? Did you select Everything and Browsing and > > Download history from Clear Recent History? > > CTRL + SHIFT + DEL -> Dropdown: All/Complete -> Checkboxes: Everything whats > possible. Thanks this is indeed fine. > > How did you remove bookmarks? > CTRL + SHIFT + B -> Select All, DEL you mean in each of toolbar/menu/unsorted? > > How much time did you wait after clearing history before checking the > > suggestions? > > Differnt. Could Also reproduce this after a Browser restart. Restart doesn't matter much, btw also the wait time shouldn't matter since you did a full clear history. > In which file are those suggestions / from which file are they produced? I > could not reproduce the faulty behaviour with a new Browser-Profile. places.sqlite database. Btw, if you do the same search in the sidebar, do you see any entry reported? Both in history (ctrl+h) and bookmarks (ctrl+b)

(In reply to Marco Bonardo [:mak] from comment #8) > (In reply to mozilla from comment #7) > places.sqlite database. > Btw, if you do the same search in the sidebar, do you see any entry reported? > Both in history (ctrl+h) and bookmarks (ctrl+b) No, they don't show up in the sidebar (neither history nor bookmarks). I just had a look at the places.sqlite... I removed the file and surprise, surprise FF creates a new one and the error is gone.

I have the same problem in firefox 15.0.1. I like to keep my history, but I delete unnecessary items, or things I just don't want them to be there anymore. However when I type in the location bar, some of the deleted items appear there. They don't have the little images on their left that usually history or bookmarked items have, but they are still there which defeats the purpose of deleting them. Please have a look into it. Thank you. PS. I wouldn't like to delete all the history.

(In reply to mozilla from comment #9) > I just had a look at the places.sqlite... I removed the file and surprise, > surprise FF creates a new one and the error is gone. well yes, you basically removed history. Do you still have the old file? could you mail it to me?

(In reply to Ket from comment #10) > They don't have the little images on their left that usually > history or bookmarked items have, but they are still there which defeats the > purpose of deleting them. Please have a look into it. Thank you. > PS. I wouldn't like to delete all the history. Please check the above suggestions and answer questions I posted before as well. If you could mail me your places.sqlite file (provided it's not too huge) that would be useful to debug. Just don't attach it here cause it contains your private data.

(In reply to Marco Bonardo [:mak] from comment #12) > Please check the above suggestions and answer questions I posted before as > well. > If you could mail me your places.sqlite file (provided it's not too huge) > that would be useful to debug. Just don't attach it here cause it contains > your private data. I apologize (and please don't take it personally) but I don't feel very comfortable with sharing the places.sqlite file. However when opening it with SQLite Database Browser there is nothing there. When I open other sqlite files (like formhistory, download, addons, etc) everything is there. Is this odd? I have windows 7 x64, ff 15.0.1, addons: adblock plus, ghostery, flashgot, formhistory control, tabmix plus, wot, adobe acrobat & flash, silvelight, Java, all latest versions. Thank you.

(In reply to Ket from comment #13) > > I apologize (and please don't take it personally) but I don't feel very > comfortable with sharing the places.sqlite file. However when opening it > with SQLite Database Browser there is nothing there. When I open other > sqlite files (like formhistory, download, addons, etc) everything is there. > Is this odd? > I had the same issue, that I could not display contents of places.sqlite with sqlbrowser.

(In reply to Ket from comment #13) > (In reply to Marco Bonardo [:mak] from comment #12) > However when opening it > with SQLite Database Browser there is nothing there. When I open other > sqlite files (like formhistory, download, addons, etc) everything is there. > Is this odd? May just mean either the version of SQLite Database Browser you used is old and not compatible with the version we used, or you tried to open the DB while Firefox was open. Try using Sqlite Manager, it's a Firefox Add-on. > I have windows 7 x64, ff 15.0.1, addons: adblock plus, ghostery, flashgot, > formhistory control, tabmix plus, wot, adobe acrobat & flash, silvelight, > Java, all latest versions. I don't know if wot uses history or bookmarks, otherwise other add-ons look safe. Please try running the cleanup tasks from https://addons.mozilla.org/en-US/firefox/addon/places-maintenance/ and see if that helps. Though, without an example database I don't have enough info to debug this atm.

(In reply to Marco Bonardo [:mak] from comment #15) > May just mean either the version of SQLite Database Browser you used is old > and not compatible with the version we used, or you tried to open the DB > while Firefox was open. I think I have the latest version of SQLite Database Browser (2.0 b1) and I had firefox closed. > Please try running the cleanup tasks from > https://addons.mozilla.org/en-US/firefox/addon/places-maintenance/ > and see if that helps. I ran the addon, did all the cleanings but deleted history items still show up. This is the log: > Integrity check + The database is sane > Reindex + The database has been reindexed > Orphans expiration + Database cleaned up > Coherence check + The database is coherent > Vacuum Initial database size is 10240 KiB + The database has been vacuumed Final database size is 10240 KiB > Statistics Database size is 10240 KiB user_version is 21 page_size is 32768 cache_size is 128 journal_mode is wal synchronous is 1 History can store a maximum of 100582 unique pages Table moz_places has 6268 records Table moz_historyvisits has 10054 records Table moz_inputhistory has 224 records Table moz_hosts has 1417 records Table moz_bookmarks has 1487 records Table moz_bookmarks_roots has 5 records Table moz_keywords has 0 records Table sqlite_sequence has 0 records Table moz_favicons has 666 records Table moz_anno_attributes has 10 records Table moz_annos has 1177 records Table moz_items_annos has 807 records Table sqlite_stat1 has 15 records Index sqlite_autoindex_moz_inputhistory_1 Index sqlite_autoindex_moz_hosts_1 Index sqlite_autoindex_moz_bookmarks_roots_1 Index sqlite_autoindex_moz_keywords_1 Index sqlite_autoindex_moz_favicons_1 Index sqlite_autoindex_moz_anno_attributes_1 Index moz_places_faviconindex Index moz_places_hostindex Index moz_places_visitcount Index moz_places_frecencyindex Index moz_places_lastvisitdateindex Index moz_historyvisits_placedateindex Index moz_historyvisits_fromindex Index moz_historyvisits_dateindex Index moz_bookmarks_itemindex Index moz_bookmarks_parentindex Index moz_bookmarks_itemlastmodifiedindex Index moz_places_url_uniqueindex Index moz_places_guid_uniqueindex Index moz_bookmarks_guid_uniqueindex Index moz_annos_placeattributeindex Index moz_items_annos_itemattributeindex

(In reply to Ket from comment #16) > I think I have the latest version of SQLite Database Browser (2.0 b1) and I > had firefox closed. May still not be compatible, I don't know that software, sorry. Just try SQLite Manager Add-on, since it uses our internal SQLite library. Nothing strange in the debug data, looks like you have about 1400 bookmarks and 100000 pages with history. How did you remove the history entries? Could you try to search in the sidebar as I suggested at the end of comment 8?

(In reply to Marco Bonardo [:mak] from comment #17) > May still not be compatible, I don't know that software, sorry. Just try > SQLite Manager Add-on, since it uses our internal SQLite library. I can open it with SQLite Manager. > Nothing strange in the debug data, looks like you have about 1400 bookmarks > and 100000 pages with history. How did you remove the history entries? Could > you try to search in the sidebar as I suggested at the end of comment 8? I usually open the Library and delete just the items that I don't want by highlighting them and press the delete button. The deleted ones don't show on the sidebar, only as suggestions in the location bar.

what if you directly delete them from the locationbar suggestion popup? could be you just missed some of the entries in the Library. If you highlight the entry in the locationbar popup and press DEL you can remove that entry from history.

(In reply to Marco Bonardo [:mak] from comment #19) > what if you directly delete them from the locationbar suggestion popup? > could be you just missed some of the entries in the Library. If you > highlight the entry in the locationbar popup and press DEL you can remove > that entry from history. I can delete them from the location bar. But they are definitely not in the library. When I do a search they don't appear there, and as I said there is a difference with these entries, they are kind of colorless, no image on the left. I'll email you a snapshot.

(In reply to Ket from comment #20) > I can delete them from the location bar. But they are definitely not in the > library. When I do a search they don't appear there, and as I said there is > a difference with these entries, they are kind of colorless, no image on the > left. I'll email you a snapshot. I suspect they may be redirects, that don't appear in common history views, you should use the Forget about this site contextual menu to cleanup results from a site properly.

(In reply to Marco Bonardo [:mak] from comment #21) > I suspect they may be redirects, that don't appear in common history views, > you should use the Forget about this site contextual menu to cleanup results > from a site properly. Thanks for the help. I understand that there may be workarounds for this issue, but as this was not happening in previous firefox versions, I still believe it's a bug. After updating to 16.0.1 it still happens. I'm gonna try to use "forget about this site" from now on and see what happens. Before, I used to press just the delete button, which obviously was slightly faster. Not to mention whatever leftovers that are still there, on which I can't apply the "forget" option, I don't know where to look for them and I will keep on discovering them only when they appear on the location bar. Somehow I believe it should be safer privacy-wise. After all that's one of the main reasons of the updates: more security. I trust it would be resolved soon.

Forgetting this site doesn't fix this problem - thats the method I use and it still comes up on autocomplete.

Also, please remember to verify that the page is not in your bookmarks.

I can confirm this bug. I've seen it for the first time in Firefox 16 and this is still there in Firefox 16.0.1. 1) These are not locally stored bookmarks. 2) Removing all locally stored data does not resolve the issue (Cache, Cookies, DOM Storage, History, ...) 3) What's even more troublesome is that even in a new private session, these history entries pop up! Is it possible that this bug is related to the more serious issue that was discovered in 16.0.0? This flaw seems not fixed. (I'm using Firefox 16.0.1 on Mountain Lion.)

(In reply to spirit from comment #25) > Is it possible that this bug is related to the more serious issue that was > discovered in 16.0.0? This flaw seems not fixed. The security fix? no that's totally unrelated.

it's probably related to redirects. a user in the support forums has provided steps to reproduce the problem (i get the same results in a new profile): https://support.mozilla.org/questions/932530#answer-364273

So I got a test db through mail, the entries were actually in history and searching for them through the Library and removing them with Forget about this site worked. Though the search tool isa bit raw, so you have to go through all results manually and remove the sites one by one with that option. For example in this case to get rid of youtube I searched "youtube.com", forgot any page with that host, then searched "youtube" and cleaned up any remaining cruft the same way (there were a couple mistyped entries. After doing this the locationbar properly stopped suggesting it. So there's no privacy leak bug in it. In the end this bug may be just the effect of 2 separate problems: 1. hard to cleanup redirects (ideally it's enough to forget the visible page though) 2. search in history is too raw, should have better filters

one easy fix we may do here is to add includeHidden=1 in the searchterms searches generated by the sidebar and library, so searching for a specific term would not filter anything matching. Other fixes may be far more complicated and take too much time.

(In reply to Marco Bonardo [:mak] from comment #28) > So I got a test db through mail, the entries were actually in history and > searching for them through the Library and removing them with Forget about > this site worked. > Though the search tool isa bit raw, so you have to go through all results > manually and remove the sites one by one with that option. > For example in this case to get rid of youtube I searched "youtube.com", > forgot any page with that host, then searched "youtube" and cleaned up any > remaining cruft the same way (there were a couple mistyped entries. After > doing this the locationbar properly stopped suggesting it. So there's no > privacy leak bug in it. That raises the question, what if I don't want to delete all history items from say youtube, but only some of them? > In the end this bug may be just the effect of 2 separate problems: > 1. hard to cleanup redirects (ideally it's enough to forget the visible page > though) > 2. search in history is too raw, should have better filters I agree, imagine you had to delete hundreds of pages one by one. And one would still have doubts over what one might have left behind, as there is nowhere to view the location bar's history. That imho could cause a privacy leak. Finally, since this was not happening in previous firefox versions it's definitely an inconvenient bug.

(In reply to Ket from comment #30) > That raises the question, what if I don't want to delete all history items > from say youtube, but only some of them? Just use common delete instead of Forget about this site. Clearly they will keep appearing in the locationbar, since they exist. > I agree, imagine you had to delete hundreds of pages one by one. And one > would still have doubts over what one might have left behind, as there is > nowhere to view the location bar's history. That imho could cause a privacy > leak. well, bookmarks and history searches are how to view the locationbar history, there's nothing more than bookmarks and history there. > Finally, since this was not happening in previous firefox versions it's > definitely an inconvenient bug. Actually it was the same, the difference is that queries were previously returning redirects too. So the problem is the confusion that creates the common delete (delete single page) from Forget about this site (delete all pages in this site so they don't appear anywhere) functionality. Previously even not understanding the difference you could select all and delete, now this doesn't work since redirects are hidden.

Plus inline autocomplete is a new feature, previously not exposed by default.

(In reply to Marco Bonardo [:mak] from comment #31) > Just use common delete instead of Forget about this site. > Clearly they will keep appearing in the locationbar, since they exist. But I am talking about the addresses theat appear on the location bar that are not showing in the library. > well, bookmarks and history searches are how to view the locationbar > history, there's nothing more than bookmarks and history there. If you remember the image I sent you several days ago by email, there are items appearing as suggestions in my location bar that don't appear in my library. Those items you suspect as redirections. I'm not 100% sure. > > Actually it was the same, the difference is that queries were previously > returning redirects too. So the problem is the confusion that creates the > common delete (delete single page) from Forget about this site (delete all > pages in this site so they don't appear anywhere) functionality. Previously > even not understanding the difference you could select all and delete, now > this doesn't work since redirects are hidden. So there are more items there than the ones showing in history and bookmarks. If they are redirects why are they hidden?

(In reply to Ket from comment #33) > (In reply to Marco Bonardo [:mak] from comment #31) > > Just use common delete instead of Forget about this site. > > Clearly they will keep appearing in the locationbar, since they exist. > > But I am talking about the addresses theat appear on the location bar that > are not showing in the library. Those won't happen if we implement comment 29 > So there are more items there than the ones showing in history and > bookmarks. If they are redirects why are they hidden? Both for performance and usability, those pages are not useful in primary ui, though they are needed for link coloring.

So, the idea is that we retain the hidden optimization for the default views (for performance and history clutter reduction), but when the user specifically searches for some terms we properly show all the existing entries. There are other solutions we may implement in future to improve privacy cleanups, but this should be a good first step allowing to find culprit entries and remove them.

Comment on attachment 680204 [details] [diff] [review] patch v1.0 I'm in favor of implying include-hidden from the fact that there's a search string, rather than adding another parameter.

(In reply to Mano from comment #37) > I'm in favor of implying include-hidden from the fact that there's a search > string, rather than adding another parameter. I thought about that, was indeed easier to implement, though, I think there are some downsides that are not well balanced with upsides: - addon-compat issue, may introduce subtle bugs hard to figure in add-ons - it complicates the documentation of searchTerms adding more special cases - it makes impossible to search without hidden (use-cases are limited, but may exist) I think it's simpler to be explicit, having to specify the option is a minor annoyance.

Comment on attachment 680204 [details] [diff] [review] patch v1.0 r=ManoConvinced

Comment on attachment 680204 [details] [diff] [review] patch v1.0 [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 737841 User impact if declined: Many users are reporting difficulties cleaning up private data due to this behavior change. The most common effect is that they forget about some page, but it keeps coming up in the locationbar. Testing completed (on m-c, etc.): m-i (waiting for merge) Risk to taking this patch (and alternatives if risky): small change (adding one relaxing filter to the searches) String or UUID changes made by this patch: none

Comment on attachment 680204 [details] [diff] [review] patch v1.0 a=me, risk is low and this will help alleviate some autocomplete pain as you mention.

I was able to reproduce this issue on Firefox 15.0.1, following STR from description, but I wasn't able to reproduce following suggestions from comment 27. User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20100101 Firefox/15.0.1 Build ID: 20120905151427 While checking this in the latest beta, I could still reproduce the issue, following STR from description. Firefox 18 beta 3 User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/20100101 Firefox/18.0 Build ID: 20121205060959 Any suggestions?

comment 0 is indeed a bit misleading compared to the final fix, point 2 is not feasible, since what is being removed is not the typed url but the redirect target url. I'll try to clarify a bit: 1. Open page A 2. Page A redirects to page B (this is a requirement, use a page that redirects) 3. type part of page A address in the locationbar, it's shown as autocomplete, but it doesn't appear in the history menu 4. open the library (Show all history) or the history sidebar, and type the same thing before the patch: 5a. Page A doesn't appear as a search result, so it's impossible to remove it after the patch: 5b. page A apppears as a search result and can be removed, once removed doesn't appear anymore in autocomplete (if the searched text is part of both page A and page B it will stop giving results as soon as both are removed)

(In reply to Marco Bonardo [:mak] from comment #47) > comment 0 is indeed a bit misleading compared to the final fix, point 2 is > not feasible, since what is being removed is not the typed url but the > redirect target url. > > I'll try to clarify a bit: > 1. Open page A > 2. Page A redirects to page B (this is a requirement, use a page that > redirects) > 3. type part of page A address in the locationbar, it's shown as > autocomplete, but it doesn't appear in the history menu > 4. open the library (Show all history) or the history sidebar, and type the > same thing > > before the patch: > 5a. Page A doesn't appear as a search result, so it's impossible to remove it > > after the patch: > 5b. page A apppears as a search result and can be removed, once removed > doesn't appear anymore in autocomplete (if the searched text is part of both > page A and page B it will stop giving results as soon as both are removed) Hi Marco! Thanks for your reply! Following the steps you describe, I wasn't able to reproduce the issue on Firefox 15.0.1, User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20100101 Firefox/15.0.1, Build ID: 20120905151427. The website I've tested is: www.litmus.mozilla.org, which after a few seconds redirects me to https://www.moztrap.mozilla.org/results/runs. The autocompletion works, but I can see www.litmus.mozilla.org both in the library and history sidebar. The webpage also appears as a search result in the history sidebar. Using the latest beta, Firefox 18 beta 4, I get the same result. Could you please give me an example of a webpage that I could test? I can't think of another one that redirects, at the moment.

ah, the redirect must be done by the server, not through js. So, I tried this test page http://jigsaw.w3.org/HTTP/300/Overview.html and clicked on the "307 Moved Temporarily" link, it loads a "307" page that redirects back, I can't see it in history menu or in Today history, but it appears in the locationbar and if I search "307" in history I see it (not without the patch). It's not the perfect example but should do.

(In reply to Marco Bonardo [:mak] from comment #49) > ah, the redirect must be done by the server, not through js. > > So, I tried this test page http://jigsaw.w3.org/HTTP/300/Overview.html and > clicked on the "307 Moved Temporarily" link, it loads a "307" page that > redirects back, I can't see it in history menu or in Today history, but it > appears in the locationbar and if I search "307" in history I see it (not > without the patch). It's not the perfect example but should do. Based on these informations, the issue is fixed on Firefox 18 beta 4. User Agent: Mozilla/5.0 (Windows NT 6.1; rv:18.0) Gecko/20100101 Firefox/18.0 Build ID: 20121212073002 Thank you Marco very much for your assistance.

I find this bug is not fixed on latest m-c... [Environment] * Nightly 20, http://hg.mozilla.org/mozilla-central/rev/a812ef63de87 * Intel Mac OS X 10.8 [STR] 0. Clean profile 1. Open the google's search page with input some word in search-bar. 2. Remove (1)'s history from history panel. 3. Type 'google' in location bar. [Result] Show up the entry which is removed in (2).

Can you file a new bug? It's generally a bad idea to reopen fixed bugs unless their patches are being backed out.

(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #52) > Can you file a new bug? It's generally a bad idea to reopen fixed bugs > unless their patches are being backed out. OK. I'm sorry for re-opening this bug. I filed Bug 826125.

thie bug is fixed "when searching history", as its title states, in your case you were not searching history. Btw, answered in the other bug.