We think that in interests of 4xp, and to better distinguish from Add Bookmark, the Add Bookmark As menu item shd be renamed as "File Bookmark". It is pretty close to the 4.x File Bookmark functionality enough to have the same name.

nominating for nsbeta1 as this is a key mozilla0.9.1 feature!

I think that 'Add Bookmark As...' is supposed to be the bookmark equivilant of 'Save As...' - it asks the user where they want the bookmark and what to call it. The name doesn't sound quite right though.

As the person who proposed the wording `Add Bookmark As ...' to begin with, I agree entirely with this bug. Alex is correct that it was meant to be analagous to `Save As ...'; but on reflection, it does sound rather corny, and it makes it rather hard to tell the difference between the two items. I'd been trying to think of a better name of it for the past few days, and couldn't; but `File Bookmark ...' sounds exellent. Stephen D, this looks right up your alley.

Shouldn't we change the accesskey, too? Index: navigator.dtd =================================================================== RCS file: /cvsroot/mozilla/xpfe/browser/resources/locale/en-US/navigator.dtd,v retrieving revision 1.117 diff -u -r1.117 navigator.dtd --- navigator.dtd 2001/04/18 05:49:48 1.117 +++ navigator.dtd 2001/04/25 22:43:00 @@ -121,8 +121,8 @@ <!ENTITY addCurPageCmd.label "Add Bookmark"> <!ENTITY addCurPageCmd.accesskey "b"> <!ENTITY addCurPageCmd.commandkey "d"> -<!ENTITY addCurPageAsCmd.label "Add Bookmark As..."> -<!ENTITY addCurPageAsCmd.accesskey "a"> +<!ENTITY addCurPageAsCmd.label "File Bookmark As..."> +<!ENTITY addCurPageAsCmd.accesskey "f"> <!ENTITY manBookmarksCmd.label "Manage Bookmarks..."> <!ENTITY manBookmarksCmd.accesskey "m"> <!ENTITY manBookmarksCmd.commandkey "b">

taking.

Stephen, shouldn't that be just `File Bookmark...'? I don't see why we'd want the `As...' after it anymore.

I strongly disagree with this. In 4.x, File Bookmark was a cascading menu where you could select a folder to put your bookmark in. It was an extremely useful feature and there is a bug on reimplementing it: bug 41888. If you rename this, not only will it cause confusion for 4.x users immediately, but it will cause even more when that RFE gets done and either has a new name or we have to change this one back. The current Add Bookmark UI is, IMO, horribly clunky compared to the 4.x File Bookmark behaviour. It makes it far more complicated in the common case. I am happy to accept that some people like it, but I don't want it stealing the name :-) Gerv

How about 'Add Bookmark To...' instead of 'Add Bookmark As...'?

Gerv, I regret to say that there will probably never be three different items in the `Bookmarks' menu with which to add a bookmark. Two is probably the maximum we can get away with, and one of those will be the simple addition. So either the dialog will stay, or the 4.x-style submenu system will arrive and the dialog will go. I think the dialog is better than the 4.x-style system in at least seven different ways (that I can think of right now), but that's outside the scope of this bug. No matter which item is retained, I think it is good for 4.x users looking for `File Bookmark' to find the new item also labelled `File Bookmark' (with an ellipsis, if it is the dialog version). Because it's the item which does what they're looking for (folder-specific filing), even if it has a different UI from the same function in 4.x.

<sulk> I see your point. Well, can we at least make the tree control on that silly box a bit longer? And have it select the New Bookmarks Folder by default? And get the "Use Default" button to update the UI in some way? And focus "OK" by default? And why doesn't the New Bookmark Folder have a different icon? And... </me goes away to make his own skin> Gerv

Well, I'm sorry to hear that. The old "File Bookmark" option is much more convenient to use than the new dialog (tree controls are a lot of work, and it adds no new functionality that I have any use for), but if you want two options, how about using "add bookmark as" and "file bookmark" and just lose the "add bookmark" option? In any event, the dialog is a glaring exception to the minimalist UI philosophy that dominates the rest of the modern theme.

All three methods of adding bookmarks have advantages: Add Bookmark - Quickly adds bookmark to default location. Nice and simple, easy to activate with a keyboard shortcut. No fuss. You may have to sort out your bookmarks later, but I think a lot of users probably do have bookmark housekeeping sessions (particularly advanced ones). And who are we to say that's the wrong way? It's no different to shoving a load of papers in a folder and sorting them out later. Add Bookmark As.../To.../Whatever We Decide To Call It... - Allows fine tuning of bookmark name and location. Makes the user organise their bookmarks well, which may be popular with novice users, but power users may be irritated by a dialogue demanding that they do this task now rather than later. File Bookmark (Cascading Menu) - Nice way to place a bookmark in the folder you want with just a few mouse movements and a single click, but doesn't let you edit anything else. It's a sort of medium between the two. I'm always in favour of giving users multiple ways to do one task, but I agree that three different menu items could maybe be a bit too much. The point I wanted to make was that if things stay the way they are now (in this bug), 'File Bookmark' (referring to the 'Add Bookmark As...' dialogue functionality) could be confused with 'Manage Bookmarks...', so I'd suggest 'File New Bookmark' instead.

How bout a pref? I personally like the N4 way of filing bookmarks, not the IE way that Mozilla has gone with. Seeing how the functionality is already there to do it the old way (in the Manage Bookmarks window), why not allow advanced users to change (in Preferences dialog)what they want "File Bookmark" to do? I know it's a long shot, but it seems like an ideal compromise to me.

I'll be happy to take this bug back when a consensus has been reached, but until then, putting this bug in more capable hands.

Fixed.

VERIFIED FIxed with 2001061415 builds on all platforms