Closed
Bug 774870
Opened 12 years ago
Closed 11 years ago
Work - Display unicode characters properly in the location field of the Firefox app bar
Categories
(Firefox for Metro Graveyard :: App Bar, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 24
People
(Reporter: jwilde, Assigned: jwilde)
References
Details
(Whiteboard: feature=work)
Attachments
(1 file)
(deleted),
patch
|
fryn
:
review+
|
Details | Diff | Splinter Review |
It seems like we lost some of the conversion of URL-encoded characters to beautiful unicode characters when detaching XBL bindings for the addressbar. We should look into how desktop Firefox does this and land an implementation on Metro Firefox.
Test cases:
ar.wikipedia.org
jp.wikipedia.org
Updated•12 years ago
|
Product: Firefox → Firefox for Metro
Version: unspecified → Trunk
Updated•12 years ago
|
Whiteboard: [metro-mvp?]
Updated•12 years ago
|
Whiteboard: [metro-mvp?] → [metro-mvp]
Updated•12 years ago
|
Whiteboard: [metro-mvp] → [metro-mvp] [LOE:?]
Updated•12 years ago
|
Whiteboard: [metro-mvp] [LOE:?] → [metro-mvp] [LOE:1]
Updated•12 years ago
|
Blocks: 831899
Whiteboard: [metro-mvp] [LOE:1] → [metro-mvp] [LOE:1] feature=work
Updated•12 years ago
|
Summary: Display unicode characters properly in the address bar → Work - Display unicode characters properly in the address bar
Whiteboard: [metro-mvp] [LOE:1] feature=work → feature=work
Updated•12 years ago
|
Summary: Work - Display unicode characters properly in the address bar → Work - Display unicode characters properly in the location field of the Firefox app bar
Updated•12 years ago
|
Component: General → App Bar
Comment 1•12 years ago
|
||
yea, http://ja.wikipedia.org/wiki/%E3%83%A1%E3%82%A4%E3%83%B3%E3%83%9A%E3%83%BC%E3%82%B8 is kind of ugly.
What do we need to do to fix this?
Flags: needinfo?(mbrubeck)
Comment 2•12 years ago
|
||
It looks like we might need to do something similar to this code:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml#1109
Flags: needinfo?(mbrubeck)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → hello
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•12 years ago
|
||
p=1
Assignee | ||
Comment 4•12 years ago
|
||
Applies code suggested by mbrubeck to getDisplayURI. Existing URI fixup infra seems to handle unicode input to the urlbar properly without modification.
Assignee | ||
Updated•12 years ago
|
Attachment #762299 -
Flags: review?(fyan)
Comment 5•11 years ago
|
||
Comment on attachment 762299 [details] [diff] [review]
patch v1
Review of attachment 762299 [details] [diff] [review]:
-----------------------------------------------------------------
très bien!
or, should I say, xn--trs bien-20a ;)
Attachment #762299 -
Flags: review?(fyan) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•