Closed
Bug 774895
Opened 12 years ago
Closed 12 years ago
Change thumbnail sizing to 180x270
Categories
(Marketplace Graveyard :: Developer Pages, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
2012-10-11
People
(Reporter: potch, Assigned: basta)
References
Details
As per the new mobile designs, the maximum dimensions for app thumbnails are 180x270. We'll need to start proportionally scaling the thumbnails to that size.
Additionally, when this change goes into effect, we will need to re-process all the existing screenshots for apps to meet this requirement.
Reporter | ||
Comment 1•12 years ago
|
||
If we haven't yet merged the gaia-ui branch when this work is completed, it should be landed there instead of master.
Updated•12 years ago
|
Comment 2•12 years ago
|
||
Maria, can we confirm this is the correct size we want for mobile?
Comment 3•12 years ago
|
||
(In reply to Chris Van Wiemeersch [:cvan] from comment #2)
> Maria, can we confirm this is the correct size we want for mobile?
Yes - in fact I'm pretty sure that Potch's original comment came from me confirming this in IRC or an email.
Comment 4•12 years ago
|
||
Awesome. And for Desktop, same size restriction? Or did we want something proportional?
Updated•12 years ago
|
Comment 5•12 years ago
|
||
This seems like an awesome Basta bug.
Comment 6•12 years ago
|
||
We should really do this before we go public so we don't get stuck with a bunch of blurry screenshots such as this one for Twitter: http://f.cl.ly/items/3q2F170I221N1s2i3q0i/Screen%20shot%202012-10-07%20at%208.47.47%20PM.png
Target Milestone: --- → 2012-10-11
Comment 7•12 years ago
|
||
Assignee | ||
Comment 8•12 years ago
|
||
This isn't much of a change, but it serves the purpose that cvan and I discussed offline:
https://github.com/mozilla/zamboni/commit/2aee52cb8240449c5a8eabdfa69cf889f7797575
We're not going to change the proportions of the image, because that's an irreversible change. Instead, potch can vertically center the images on the front-end. They should never end up being wider than 180 or taller than 270, though, so they'll always fit nicely.
There's also no migration here. On the front-end, we can probably say (safely) `max-width: 180px; max-height: 270px;` and it'll do what we expect. We should send an email to developers saying that they should upload new screenshots that meet the dimensions.
Comment 9•12 years ago
|
||
Let's make screenshot minimum sizes be 320x480 now.
Updated•12 years ago
|
Assignee: nobody → mattbasta
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 10•12 years ago
|
||
Verified as fixed in https://marketplace-dev.allizom.org/developers/ on FF20 (Win 7)
Postfix screencast http://screencast.com/t/6voCS1UvZo
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•