Closed
Bug 774963
Opened 12 years ago
Closed 12 years ago
Move the removeDataFromDomain API into its own service
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 18
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
(Keywords: addon-compat, dev-doc-needed)
Attachments
(1 file)
|
(deleted),
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
The private browsing service API will go away when we switch to per-window PB. We need to move the removeDataFromDomain API to its own service before that happens. That API never really belonged there, and perhaps it makes sense for us to move it to places?
|
Assignee | |
Comment 1•12 years ago
|
||
I put that method in its own JS module, ClearRecentHistory.
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Comment on attachment 667596 [details] [diff] [review]
Patch (v1)
Review of attachment 667596 [details] [diff] [review]:
-----------------------------------------------------------------
The contents of removeDataFromDomain are just itching to move to the actual components that own the data, but I'll just file a bug about that some other time.
Attachment #667596 -
Flags: review?(josh) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
(In reply to comment #3)
> The contents of removeDataFromDomain are just itching to move to the actual
> components that own the data, but I'll just file a bug about that some other
> time.
Well, that stuff should probably get rewritten at some point for performance (by not doing all sorts of terrible sync io on the main thread. I'm not sure if the refactoring as you suggest it is going to be worth it on its own...
|
||
Comment 5•12 years ago
|
||
Try run for 84020ccc0708 is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=84020ccc0708
Results (out of 13 total builds):
success: 12
failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-84020ccc0708
|
|
Assignee | |
Comment 6•12 years ago
|
||
Target Milestone: --- → Firefox 18
|
|
Assignee | |
Updated•12 years ago
|
Keywords: addon-compat
|
|
Assignee | |
Updated•12 years ago
|
Keywords: dev-doc-needed
|
||
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•