Closed
Bug 774980
Opened 12 years ago
Closed 12 years ago
Hook up nsCSSKeyframeRule to cycle collection
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
It holds a ref to the nsCSSKeyframeStyleDeclaration.
Assignee | ||
Comment 1•12 years ago
|
||
So one issue here is that the superclass is not CCed, so I would be adding my own refcount instead of reusing the one from there...
Can I make the superclass use the CC refcount without implementing CC? Seems like we'll want CC on Rule at some point anyway, right?
Depends on: 753517
Comment 2•12 years ago
|
||
The main issue that I can see is that the CC refcount will add and remove the object from the purple buffer. When the CC examines things in the purple buffer, it tries to QI to nsCycleCollectionISupports, which will end up in null, I assume, which the CC won't deal with, and you'll get null derefs and assertion failures. I guess you could make it into a dummy CC class that has an empty traverse/unlink.
Comment 3•12 years ago
|
||
I don't know if we want to add CC to Rule, are all its subclasses exposed through the DOM? Do we ever create instances of Rule directly? If not we could push refcounting to the subclasses. I wonder if the CC AddRef/Release being slower will matter here :-/.
Assignee | ||
Comment 4•12 years ago
|
||
> are all its subclasses exposed through the DOM?
No. The most common one (StyleRule) is not.
So maybe moving refcounting out of Rule is the right way to go....
Assignee | ||
Comment 5•12 years ago
|
||
For what it's worth, I'm moving refcounting out of Rule in bug 795221. At that point, this should be pretty straightforward, I think.
Depends on: 795221
Assignee | ||
Comment 6•12 years ago
|
||
Attachment #703751 -
Flags: review?(bugs)
Assignee | ||
Updated•12 years ago
|
Whiteboard: [need review]
Updated•12 years ago
|
Attachment #703751 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 7•12 years ago
|
||
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla21
Comment 8•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•