Closed Bug 775278 Opened 12 years ago Closed 8 years ago

Some EGL extension checks are missing

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

Attachments

(1 file, 1 obsolete file)

Some paths don't check the proper EGL extensions before using them.
Attached patch Add missing extension checks (obsolete) (deleted) — Splinter Review
More extension checks.
Attachment #643584 - Flags: review?
Attachment #643584 - Flags: review? → review?(bgirard)
Why do some ext check get their own helper and not others? It's seems very arbitrary.
Attachment #643584 - Flags: review?(bgirard) → review+
We should really only use helpers when using IsExtensionSupported is onerous or tricky, as with EGL_KHR_image support (provided by either EGL_KHR_image or EGL_KHR_image_base) and EGL_KHR_image_pixmap (either EGL_KHR_image or EGL_KHR_image_pixmap).
Also EGLLibrary used to not have the same extension checking machinery, and just had a few bits with explicit helper functions. Could go either way, really -- you could always flag EGL_KHR_image as present if the required component extensions are present whether it's actually reported or not in the string, too.
(In reply to Vladimir Vukicevic [:vlad] [:vladv] from comment #4) > Also EGLLibrary used to not have the same extension checking machinery, and > just had a few bits with explicit helper functions. Could go either way, > really -- you could always flag EGL_KHR_image as present if the required > component extensions are present whether it's actually reported or not in > the string, too. This is also possible, though a little tricky. Technically if it supports EGL_KHR_image but not EGL_KHR_image_base, it's nearly identical, save for the PRESERVE EGLImage creation option.
I necromanced this.
Attachment #643584 - Attachment is obsolete: true
Attachment #8628461 - Flags: review?(dglastonbury)
Attachment #8628461 - Flags: review?(dglastonbury) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: