Closed Bug 77596 Opened 24 years ago Closed 23 years ago

context menus have redundant separator at the end

Categories

(Core :: DOM: Editor, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla0.9.2

People

(Reporter: bugzilla, Assigned: cmanske)

References

Details

(Whiteboard: [ui] fixed)

Attachments

(1 file)

in the composer content region, i've noticed that the context [popup] menus have a separator at the end --there shouldn't be one. i have seen this when: * right-clicking on a blank region [nothing selected] * right-clicking on selected, unlinked text i do *not* see the extra separator when: * right-clicking over an image * right-clicking over a link * right-clicking within a cell of a table * right-clicking over a selected table
this also occurs in the mail message pane, as well as the mail standalone window, bug 72611.
Depends on: 75338
Summary: context menus have extra separator at the end → context menus have redundant separator at the end
The context menus in mail windows are completely separate implementations and should be separate bugs.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.2
Keywords: correctness
Priority: -- → P3
Whiteboard: [ui]
*** Bug 83309 has been marked as a duplicate of this bug. ***
Attached patch Fix. (deleted) — Splinter Review
Simple fix. Central change was moving existing test for image element up in the method. Cleaned up dumps.
Keywords: patch, review
Whiteboard: [ui] → [ui] FIX IN HAND need r=, sr=
Note there still seems to be more space than there should be at the end of the context menu There's *many* menuitems and separators hidden, i.e., "collapsed" in that state, so maybe there's a small accumlation of space because of that (i.e., collapsed doesn't result in "0" pixels?) Anyway, that problem is general XPFE or themes; can't do anything about it in Composer. At least this eliminates the extra separator.
sr=kin
Whiteboard: [ui] FIX IN HAND need r=, sr= → [ui] FIX IN HAND need r=
r=sfraser
Whiteboard: [ui] FIX IN HAND need r= → [ui] FIX IN HAND
Blocks: 83989
a= asa@mozilla.org for checkin to the trunk. (on behalf of drivers)
Whiteboard: [ui] FIX IN HAND → [ui] fixed, reviewed, a=asa
checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Keywords: patch, review
Resolution: --- → FIXED
Whiteboard: [ui] fixed, reviewed, a=asa → [ui] fixed
still not fixed....I still see separator when there is nothing in the page....blank page...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
actually it works.
Status: REOPENED → RESOLVED
Closed: 23 years ago23 years ago
Resolution: --- → FIXED
verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: