if you crash soon after importing Outlook Express email, you will lose the imported account to reproduce this: start up, import mail from OE. when complete, see that you have an "Outlook Express" account in the folder pane. before doing anything else, kill the app. when you start back up, there is no "Outlook Express" account. this is bad, since mozilla is hardly crash proof. we must not be saving prefs after import. (It probably happens with Eudora, I haven't tried.) note, if you gracefully shut down, when you restart your OE account will be there. cavin, interested in this one? should be a quick fix.

reassigning to cavin

Just to be more sepcific about reproducing the problem: 1. Start up mail program and import mail from OE. 2. When complete, you may see that you have an "Outlook Express" account in the folder pane. 3. Before doing anything else (i.e., DO NOT click on the Finish button), kill the app (on windows, you can launch Task Manager and End Task from there). 4. Re-start mail and the "Outlook Express" account in the folder pane is gone!

The same problem happens to the following scenarios as well: 1. Eudora mail import. 2. Eudora Settings import. 3. OE Settings import. 4. News reading from a browser.

what about this scenario: 5) new profile, never launched mail. click on a mailto: link or do File | New Message

This scenario does work but the java script should use the same account manager interface API to save the account info to prefs file (ie, saveAccountInfo).

cavin, is your tree up to date? I think the SavePrefFile() api has switched on you again (to taking 1 arg). update you tree, I think you'll fail to build. also, you don't need the newline in your assertions: NS_ASSERTION(NS_SUCCEEDED(rv), "Can't save account info to pref file\n"); should be NS_ASSERTION(NS_SUCCEEDED(rv), "Can't save account info to pref file"); I've got your original patch, plus the SavePrefFile() fix (and the change to your assertions) in my local tree. I'll finish testing and land it tomorrow. (no need for you to attach a new patch.)

Seth, my tree is a few days old. Tried to update it yesterday but cvs failed on me. Will do that today. I cut and pasted the NS_ASSERTION() call from somewhere and it has "\n" in the error msg too. Thanks for catching the problems.

fixed.

Build 2001-05-04-04: WinME Verified Fixed, for the following scenarios: 1. Cavin's scenario from 4/26 (Import OE Mail and forct a quit) 2. Cavin's scenario from 4/30 (Import Eudora Settings, imp OE Settings, News via the browser creates the news account and newsgroup displays the messages. I had to select the Mail window but that's a different bug) 2. Seth's scenario from 4/30 (New profile, File|New Message, opens new message window, opens account wizard, progress through wizard, finish wizard and new message window auto fills from field with new account info and message sends successfully, focus goes back to the browser)