When enable usb tethering, the usb driver will create a rndis network interface. Rather than hard code the name, we need to get it automatically. The default name for ICS is "rndis0".

The interface name could be one of rndis0/usb0.... My approach is to get network interface lists and compare them with possible name lists.

The interface name of rndis could be one of rndis0(unagi)/usb0(leo).... My approach is to get network interface lists from /sys/class/net and compare them with possible name lists.

Comment on attachment 743539 [details] [diff] [review] Possible fix, patch v1.0 Review of attachment 743539 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/NetworkManager.js @@ +848,5 @@ > + getUsbInterface: function getUsbInterface() { > + let array = []; > + try { > + let file = new FileUtils.File(KERNEL_NETWORK_ENTRY); > + let entries = file.directoryEntries; Wouldn't it make more sense to just iterate over this.possibleInterface and check to see if /sys/class/net/NAME exists? At least, then you can prioritize, and stop when you find the first entry that matches. Fundamentally, I don't have any issues with this approach either, it just seemed odd to me.

(In reply to Dave Hylands [:dhylands] from comment #3) > Comment on attachment 743539 [details] [diff] [review] > Possible fix, patch v1.0 > > Review of attachment 743539 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/system/gonk/NetworkManager.js > @@ +848,5 @@ > > + getUsbInterface: function getUsbInterface() { > > + let array = []; > > + try { > > + let file = new FileUtils.File(KERNEL_NETWORK_ENTRY); > > + let entries = file.directoryEntries; > > Wouldn't it make more sense to just iterate over this.possibleInterface and > check to see if /sys/class/net/NAME exists? > > At least, then you can prioritize, and stop when you find the first entry > that matches. > > Fundamentally, I don't have any issues with this approach either, it just > seemed odd to me. Thanks for your quick feedback, I am going to post a new patch to address your comment. Please help me to double check it.

This should be mark as LEO+, we need this patch to make usb tethering work on LEO.

Comment on attachment 744410 [details] [diff] [review] Patch to address review comment 3, patch v1.1 Review of attachment 744410 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/NetworkManager.js @@ +863,5 @@ > + } > + > + // Find the rndis interface. > + for (let i = 0; (array.length > 0 && > + i < this.possibleInterface.length); i++) { I was thinking more along the lines of removing lines 849 thru 863 and replacing lines 868 to 869 with: let file = new FileUtils.File(KERNEL_NETWORK_ENTRY + "/" + this.possibleInterface[i]); if (file.IsDirectory()) { return this.possibleInterface[i]; } (and adding in an appropriate try/catch block)

Triage 5/3- Leo+ base on comment 6