Open
Bug 776324
Opened 12 years ago
Updated 2 years ago
remove support for RFC 2231 continuation parameters in HTTP header field parameters
Categories
(Firefox :: File Handling, defect)
Firefox
File Handling
Tracking
()
NEW
People
(Reporter: julian.reschke, Unassigned)
References
(Depends on 1 open bug, Blocks 1 open bug, )
Details
Attachments
(1 file)
(deleted),
patch
|
jduell.mcbugs
:
review-
|
Details | Diff | Splinter Review |
RFC 2231 parameter continuations aren't needed in HTTP (which doesn't have MIME's line length restrictions), and aren't widely implemented (see http://greenbytes.de/tech/tc2231/#encoding-2231-cont -- they are unsupported in Safari, Chrome, and IE).
The existing code will need to be kept for MIME header field parsing (as long as the mail client uses nsMIMEHeaderParams) though.
Reporter | ||
Comment 1•12 years ago
|
||
Attachment #644750 -
Flags: review?(jduell.mcbugs)
Comment 2•12 years ago
|
||
Comment on attachment 644750 [details] [diff] [review]
Proposed patch
Review of attachment 644750 [details] [diff] [review]:
-----------------------------------------------------------------
This doesn't look like a patch to remove support for RFC 2231 continuation parameters in HTTP header fields: it looks like a patch to remove some old broken-but-long-supported content-disposition behaviors (like using 'name' instead of 'filename'. Did you attach the right patch here Julian?
Attachment #644750 -
Flags: review?(jduell.mcbugs) → review-
Reporter | ||
Comment 3•12 years ago
|
||
(In reply to Jason Duell (:jduell) from comment #2)
> Comment on attachment 644750 [details] [diff] [review]
> Proposed patch
>
> Review of attachment 644750 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> This doesn't look like a patch to remove support for RFC 2231 continuation
> parameters in HTTP header fields: it looks like a patch to remove some old
> broken-but-long-supported content-disposition behaviors (like using 'name'
> instead of 'filename'. Did you attach the right patch here Julian?
No, I did not. Sorry for the confusion :-)
Reporter | ||
Comment 4•12 years ago
|
||
(In reply to Julian Reschke from comment #3)
> No, I did not. Sorry for the confusion :-)
Actually, it was the correct patch applied to the wrong bug :-)
Updated•8 years ago
|
Product: Core → Firefox
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•