Closed
Bug 77639
Opened 24 years ago
Closed 24 years ago
confirm profile migration dialog sized incorrectly
Categories
(Core Graveyard :: Profile: Migration, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.1
People
(Reporter: danm.moz, Assigned: danm.moz)
Details
Attachments
(1 file)
|
(deleted),
image/jpeg
|
Details |
Screenshot of problem
Destroy your profile. (On Win2K for instance, rm -r <rootdrive>:/Documents and
Settings/<username>/Application Data/Mozilla). Launch Mozilla. The "confirm
migration" dialog is generally clipped at the bottom, halfway through the
button. Note I'm only seeing this on my Windows build, classic skin (that's what
you get during profile migration, isn't it?). Linux and Mac both look fine.
I suspect this is truly a bug in the box intrinsic sizing code. Maybe that wants
looking at, but this patch which forces the dialog to a more reasonable width
apparently fixes the problem and makes the dialog look better anyway. I post it
as a suggestion.
Index: ./profile/resources/content/confirmMigration.xul
===================================================================
RCS file: /cvsroot/mozilla/profile/resources/content/confirmMigration.xul,v
retrieving revision 1.10
diff -u -r1.10 confirmMigration.xul
--- confirmMigration.xul 2001/03/13 15:35:03 1.10
+++ confirmMigration.xul 2001/04/26 00:27:17
@@ -31,7 +31,7 @@
<spring flex="1"/>
</box>
<separator orient="vertical" class="thin"/>
- <box orient="vertical" flex="1">
+ <box orient="vertical" flex="1" class="longwrappedtext">
<html>&confirmMigrationPart1.label;</html>
<html>&confirmMigrationPart2.label;</html>
</box>
Index: ./themes/classic/communicator/profile/mac/profile.css
===================================================================
RCS file: /cvsroot/mozilla/themes/classic/communicator/profile/mac/profile.css,v
retrieving revision 1.1
diff -u -r1.1 profile.css
--- profile.css 2000/09/15 06:14:01 1.1
+++ profile.css 2001/04/26 00:27:18
@@ -31,4 +31,8 @@
#contentarea
{
padding : 7px 5px 7px 5px;
- }
\ No newline at end of file
+ }
+
+box.longwrappedtext {
+ max-width: 40em;
+}
Index: ./themes/classic/communicator/profile/profile.css
===================================================================
RCS file: /cvsroot/mozilla/themes/classic/communicator/profile/profile.css,v
retrieving revision 1.5
diff -u -r1.5 profile.css
--- profile.css 2001/04/17 02:53:56 1.5
+++ profile.css 2001/04/26 00:27:08
@@ -67,3 +67,9 @@
box.selection {
margin-top: 4px;
}
+
+/* ::::: confirmation dialog ::::: */
+
+box.longwrappedtext {
+ max-width: 40em;
+}
Index: ./themes/modern/communicator/profile/profile.css
===================================================================
RCS file: /cvsroot/mozilla/themes/modern/communicator/profile/profile.css,v
retrieving revision 1.5
diff -u -r1.5 profile.css
--- profile.css 2001/03/16 02:37:30 1.5
+++ profile.css 2001/04/26 00:27:15
@@ -60,3 +60,9 @@
#finishtext {
margin-top: -20px;
}
+
+/* ::::: confirmation dialog ::::: */
+
+box.longwrappedtext {
+ max-width: 40em;
+}
(cc:ed evaughan because of my suspicion that it really is a problem, as
mentioned above.)
|
||
Updated•24 years ago
|
Component: XP Apps → Profile Migration
QA Contact: sairuh → gbush
|
||
Comment 2•24 years ago
|
||
I am seeing the problem too ... NT 4.0, latest build 2001043004 (0.9.1 I assume)
Note that the dialog also is resizable ... this does not seem necessary.
|
|
||
Comment 3•24 years ago
|
||
See a comment/patch made today in bug 68352 which will at least fix window button
clipping in general. It leaves unaddressed the problem that this window is still
given an unattractive intrinsic size.
Truncation is fixed, unpleasant default size is not. See bug 68352.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•