Closed Bug 776408 Opened 12 years ago Closed 6 years ago

do not inline autocomplete after a paste, and remove the old delay-on-paste code

Categories

(Firefox :: Address Bar, defect, P5)

defect
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 68
Iteration:
68.3 - Apr 15 - 28
Tracking Status
firefox68 --- fixed

People

(Reporter: bruant.d, Assigned: mak)

References

Details

(Whiteboard: [unifiedcomplete][fxsearch])

Attachments

(2 files)

A friend shared 2 URLs (which were in full text and not clickable links) of her music (order is important): 1) http://soundcloud.com/dorianfinchisdead 2) http://soundcloud.com/dorianfinch Steps I took: 1) Open new tab, copy/pasted first URL, go to the page 2) Open another new tab, copy/paste the second URL, hit "enter" What I expected: * The second new tab should have the second URL loaded What actually happened: * Since the second URL is a prefix of the first one, the location bar autocompleted to the first URL and on hitting "enter", I loaded a second time the first URL. I don't see a good solution that keeps autocomplete (which is a great feature) and the actions I described lead to my expected result, but I wanted to share this experience hoping that someone else may have a great idea. From a user perspective, when I copy/pasted the URL, I knew where I wanted to go and I expected to get me there on hitting "enter".
iirc after paste there is a delay before we complete, exactly to cover this case, does it happen if you immediately confirm on paste?
Either there is no delay or the delay is too short. I retried (on another Ubuntu computer with Firefox 14. I'll retry on Aurora 16 later if you wish) and to retry I've done the following: 1) copy the second link Then, as fast as possible : 2) Ctrl + T (new tab) 3) Ctrl + V (paste) 4) enter (this combinaison is something I do fairly frequently) I still arrive on the wrong page.
ok, then there is something weird there, looks like bug 717772 missed something
Might be Linux specific. I haven't tried on Mac nor any Windows.
Summary: Abusive autocomplete → inline autocomplete not properly waiting paste delay
I confirm the bug is also present on Aurora 16 on Ubuntu.
Better not to complete at all after paste. Having behavior depend on the length of the wait would makes results even more non-deterministic: Paste. Check that it is not completed. Press enter. URL completes. Redirected. Pasted URL is gone and not available through back button. Need to erase, re-paste and try again.
OS: Linux → All
Hardware: x86 → All
Version: 16 Branch → Trunk
Blocks: 1071461
I think this regressed when we made autocomplete searches able to bypass the autocomplete timeout. I sort of agree we should probably just not autofill after a paste and remove the delay code...
Priority: -- → P3
Whiteboard: [unifiedcomplete][fxsearch]
Rank: 35
Depends on: 717772
Blocks: quantumbar-autofill
No longer blocks: quantumbar-input
Summary: inline autocomplete not properly waiting paste delay → do not inline autocomplete after a paste, and remove the old delay-on-paste code
Blocks: quantumbar
Priority: P3 → P5
No longer blocks: quantumbar
Points: --- → 3
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Iteration: --- → 68.3 - Apr 15 - 28

Depends on D28050

Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/508704365b1c Remove autocomplete delay-on-paste r=MattN https://hg.mozilla.org/integration/autoland/rev/cf4f78f532ee Do not autofill after a paste. r=adw
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: