Closed
Bug 776408
Opened 12 years ago
Closed 6 years ago
do not inline autocomplete after a paste, and remove the old delay-on-paste code
Categories
(Firefox :: Address Bar, defect, P5)
Firefox
Address Bar
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: bruant.d, Assigned: mak)
References
Details
(Whiteboard: [unifiedcomplete][fxsearch])
Attachments
(2 files)
A friend shared 2 URLs (which were in full text and not clickable links) of her music (order is important):
1) http://soundcloud.com/dorianfinchisdead
2) http://soundcloud.com/dorianfinch
Steps I took:
1) Open new tab, copy/pasted first URL, go to the page
2) Open another new tab, copy/paste the second URL, hit "enter"
What I expected:
* The second new tab should have the second URL loaded
What actually happened:
* Since the second URL is a prefix of the first one, the location bar autocompleted to the first URL and on hitting "enter", I loaded a second time the first URL.
I don't see a good solution that keeps autocomplete (which is a great feature) and the actions I described lead to my expected result, but I wanted to share this experience hoping that someone else may have a great idea.
From a user perspective, when I copy/pasted the URL, I knew where I wanted to go and I expected to get me there on hitting "enter".
Assignee | ||
Comment 1•12 years ago
|
||
iirc after paste there is a delay before we complete, exactly to cover this case, does it happen if you immediately confirm on paste?
Reporter | ||
Comment 2•12 years ago
|
||
Either there is no delay or the delay is too short.
I retried (on another Ubuntu computer with Firefox 14. I'll retry on Aurora 16 later if you wish) and to retry I've done the following:
1) copy the second link
Then, as fast as possible :
2) Ctrl + T (new tab)
3) Ctrl + V (paste)
4) enter
(this combinaison is something I do fairly frequently)
I still arrive on the wrong page.
Assignee | ||
Comment 3•12 years ago
|
||
ok, then there is something weird there, looks like bug 717772 missed something
Reporter | ||
Comment 4•12 years ago
|
||
Might be Linux specific. I haven't tried on Mac nor any Windows.
Assignee | ||
Updated•12 years ago
|
Summary: Abusive autocomplete → inline autocomplete not properly waiting paste delay
Reporter | ||
Comment 5•12 years ago
|
||
I confirm the bug is also present on Aurora 16 on Ubuntu.
Comment 6•9 years ago
|
||
Better not to complete at all after paste.
Having behavior depend on the length of the wait would makes results even more non-deterministic:
Paste.
Check that it is not completed.
Press enter.
URL completes.
Redirected. Pasted URL is gone and not available through back button.
Need to erase, re-paste and try again.
Assignee | ||
Updated•9 years ago
|
OS: Linux → All
Hardware: x86 → All
Version: 16 Branch → Trunk
Assignee | ||
Comment 8•9 years ago
|
||
I think this regressed when we made autocomplete searches able to bypass the autocomplete timeout.
I sort of agree we should probably just not autofill after a paste and remove the delay code...
Priority: -- → P3
Whiteboard: [unifiedcomplete][fxsearch]
Updated•9 years ago
|
Rank: 35
Updated•6 years ago
|
Blocks: quantumbar-input
Depends on: 717772
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Summary: inline autocomplete not properly waiting paste delay → do not inline autocomplete after a paste, and remove the old delay-on-paste code
Assignee | ||
Updated•6 years ago
|
Blocks: quantumbar
Priority: P3 → P5
Updated•6 years ago
|
No longer blocks: quantumbar
Assignee | ||
Updated•6 years ago
|
Points: --- → 3
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Assignee | ||
Updated•6 years ago
|
Iteration: --- → 68.3 - Apr 15 - 28
Assignee | ||
Comment 9•6 years ago
|
||
Assignee | ||
Comment 10•6 years ago
|
||
Depends on D28050
Comment 11•6 years ago
|
||
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/508704365b1c
Remove autocomplete delay-on-paste r=MattN
https://hg.mozilla.org/integration/autoland/rev/cf4f78f532ee
Do not autofill after a paste. r=adw
Comment 12•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/508704365b1c
https://hg.mozilla.org/mozilla-central/rev/cf4f78f532ee
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in
before you can comment on or make changes to this bug.
Description
•