Closed
Bug 776515
Opened 12 years ago
Closed 12 years ago
Move InternalIsSupported to nsContentUtils
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: ayg, Assigned: Ms2ger)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → Ms2ger
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #667846 -
Flags: review?(khuey)
Comment on attachment 667846 [details] [diff] [review]
Patch v1
Review of attachment 667846 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/base/src/nsContentUtils.cpp
@@ +170,5 @@
> #include "mozilla/Attributes.h"
> #include "nsIParserService.h"
> #include "nsIDOMScriptObjectFactory.h"
> #include "nsSandboxFlags.h"
> +#include "nsSVGFeatures.h"
Can you stop including nsSVGFeatures.h in FragmentOrElement.cpp?
::: content/base/src/nsDOMAttribute.cpp
@@ +445,5 @@
> bool* aReturn)
> {
> OwnerDoc()->WarnOnceAbout(nsIDocument::eIsSupported);
>
> + *aReturn = nsContentUtils::InternalIsSupported(static_cast<nsIDOMAttr*>(this),
Get rid of the trailing whitespace while you're here.
Attachment #667846 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 667846 [details] [diff] [review]
Patch v1
Review of attachment 667846 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/base/src/FragmentOrElement.cpp
@@ -112,5 @@
> #include "mozAutoDocUpdate.h"
>
> #include "prprf.h"
> #include "nsDOMMutationObserver.h"
> -#include "nsSVGFeatures.h"
Yeah, I believe I can
|
||
Comment 4•12 years ago
|
||
We might want to not land this immediately, to avoid bitrotting bug 773780.
|
|
Assignee | |
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•