Some of toolkit's XPCShell tests now require toolkit/devtools/sourcemap/tests/unit/Utils.jsm, and Utils.jsm in turn requires Require.jsm. Unfortunately, Require.jsm is only available to browser, since it's under browser/devtools/shared. This means that comm-central's XPCShell tests are busted (since we run toolkits XPCShell tests along with our own), and our tree is very orange. Can we move Require.jsm and dependencies somewhere into toolkit?

Moved to Require.jsm to toolkit as requested

http://tbpl.mozilla.org/?tree=Try&rev=af8f536b5b46 This will work as long as we are not debugging dependencies. We could also move Console.jsm but that would be robcee's call.

(In reply to Mike Conley (:mconley) from comment #0) > Some of toolkit's XPCShell tests now require > toolkit/devtools/sourcemap/tests/unit/Utils.jsm, and Utils.jsm in turn > requires Require.jsm. Why?

Comment on attachment 644947 [details] [diff] [review] Patch you should change importers of Require.jsm to resource://gre/modules/Require.jsm and update the jar file accordingly.

(In reply to Rob Campbell [:rc] (:robcee) from comment #3) > (In reply to Mike Conley (:mconley) from comment #0) > > Some of toolkit's XPCShell tests now require > > toolkit/devtools/sourcemap/tests/unit/Utils.jsm, and Utils.jsm in turn > > requires Require.jsm. > > Why? disregard that. Dave helped me understand that we're blowing up your tests.

Can we just put the module directly under toolkit/devtools, rather than in its own directory? Flatter directory structures are better!

(In reply to Rob Campbell [:rc] (:robcee) from comment #4) > Comment on attachment 644947 [details] [diff] [review] > Patch > > you should change importers of Require.jsm to > resource://gre/modules/Require.jsm and update the jar file accordingly. No jar involved but done. (In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #6) > Can we just put the module directly under toolkit/devtools, rather than in > its own directory? Flatter directory structures are better! Done

Comment on attachment 645249 [details] [diff] [review] Patch II - the sequel I'm gonna r+ to get Tbird back up and running, but I think we should probably have gre/modules/devtools as the path. I will update and land.

Comment on attachment 645522 [details] [diff] [review] require-fix follow-up fix

https://hg.mozilla.org/mozilla-central/rev/35bc0dd4080c https://hg.mozilla.org/mozilla-central/rev/40bfa9aa4ab0