Closed
Bug 776664
Opened 12 years ago
Closed 12 years ago
Check capabilities for SMS access
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
People
(Reporter: cjones, Assigned: cjones)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
This patch doesn't work currently because sms isn't hooked up to the permission manager. (I get UNKNOWN_ACTION when running this.) But cross-process sms also crashes, so this doesn't break things any further. I'm also assuming here that we want a coarse-grained "access all of the SMS API" permission, not something finer-grained like reading/writing. If that assumption is wrong, let me know.
Assignee: nobody → jones.chris.g
Attachment #645228 -
Flags: review?(mounir)
Assignee | ||
Comment 2•12 years ago
|
||
Same assumption applies.
Attachment #645228 -
Attachment is obsolete: true
Attachment #645228 -
Flags: review?(mounir)
Attachment #645686 -
Flags: review?(mounir)
Comment 3•12 years ago
|
||
Comment on attachment 645686 [details] [diff] [review] Check "sms" capability for PSms, v2 Review of attachment 645686 [details] [diff] [review]: ----------------------------------------------------------------- I would prefer to review that when all the other plumbing will be done (ie. capabilities and sms permissions). r+ a patch that doesn't work/isn't testable doesn't make that much sense. Even more when it's that trivial ;)
Attachment #645686 -
Flags: review?(mounir)
Assignee | ||
Comment 4•12 years ago
|
||
I have a working patch built on bug 776649 that I've been testing with the last two days, but will hold off posting per mounir's request. Doesn't really matter, it's a trivial patch.
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #645686 -
Attachment is obsolete: true
Updated•12 years ago
|
blocking-basecamp: --- → +
Assignee | ||
Comment 6•12 years ago
|
||
Comment on attachment 646414 [details] [diff] [review] Check "sms" capability for PSms, v3 Hope you don't mind pinch-reviewing for mounir here, but this patch is deliciously trivial.
Attachment #646414 -
Flags: review?(justin.lebar+bug)
Updated•12 years ago
|
Attachment #646414 -
Flags: review?(justin.lebar+bug) → review+
Assignee | ||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/769750c602b2
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/769750c602b2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•